Skip to content

Fix JRuby 9.4 RSpec termination race-condition #4955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix JRuby 9.4 RSpec termination race-condition #4955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/datadog/core/remote/component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ def lift

@condition.broadcast
ensure
@mutex.unlock
# NOTE: The `locked?` check is not preventing a context switching, hence
# it is not preventing a race condition. But in some rare cases
# in RSpec of JRuby 9.4 the test case will not let locking happen.
# That will cause specs to fail.
@mutex.unlock if @mutex.locked?
Copy link
Member

@p-datadog p-datadog Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does really not look right to me at all...

Copy link
Member

@p-datadog p-datadog Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal: #4957

end
end

Expand Down