-
Notifications
You must be signed in to change notification settings - Fork 399
Add support of Forwarded header for remote IP detection #4969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of Forwarded header for remote IP detection #4969
Conversation
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 841. Ignored filesNote: Ignored files are excluded from the next sections.
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 69d6e1f | Docs | Was this helpful? Give us feedback! |
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few suggestions. One is about memory
BenchmarksBenchmark execution time: 2025-10-13 14:51:19 Comparing candidate commit 69d6e1f in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:profiling - gvl benchmark samples
scenario:profiling - intern_all 1000 repeated strings
|
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Well done!
What does this PR do?
This PR adds support for
Forwardedheader for remote IP detection.Motivation:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Forwarded
Change log entry
Yes. Tracing: Add
Forwardedheader to the list of headers used for remote IP detection.Additional Notes:
None.
How to test the change?
CI