Skip to content

Conversation

@ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Nov 3, 2025

PROF-12959

What does this PR do?

This PR bumps the libdatadog dependency from version 22.0.1.1.0 to version 23.0.0.1.0.

As this new libdatadog version now compresses profiles using zstd instead of lz4, I've replaced one with the other on our tests.

Motivation:

Adopt the new, better compression for the Ruby profiler.

Change log entry

Yes. Upgrade libdatadog dependency to version 23.0.0

Additional Notes:

Other than the switch from lz4 to zstd on the Ruby profiler, I did not need to change anything to get a green test suite locally.

How to test the change?

I've tested this locally as I'm preparing to release the libdatadog gem change. I'm going to open this PR as a draft until the libdatadog gem is up on rubygems.

Update: Libdatadog v23.0.0.1.0 is on rubygems.org, this PR is ready for review!

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-11-03 18:06:47 UTC

ivoanjo added a commit to DataDog/libdatadog that referenced this pull request Nov 3, 2025
**What does this PR do?**

This PR includes the changes documented in the "Releasing a new version
to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg

**Motivation:**

Enable Ruby to use libdatadog v23.0.0. In particular, this release
switches the profile serializer to compress data using zstd instead of
lz4.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this change locally with the changes in
DataDog/dd-trace-rb#5020 and was able to get
a green test suite run for Ruby.

As a reminder, new libdatadog releases don't get automatically picked up
by dd-trace-rb, so the PR that bumps the dependency will also test this
release against all supported Ruby versions.
dd-mergequeue bot pushed a commit to DataDog/libdatadog that referenced this pull request Nov 4, 2025
[PROF-12941] Package libdatadog v23.0.0 for Ruby

**What does this PR do?**

This PR includes the changes documented in the "Releasing a new version
to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg

**Motivation:**

Enable Ruby to use libdatadog v23.0.0. In particular, this release
switches the profile serializer to compress data using zstd instead of
lz4.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this change locally with the changes in
DataDog/dd-trace-rb#5020 and was able to get
a green test suite run for Ruby.

As a reminder, new libdatadog releases don't get automatically picked up
by dd-trace-rb, so the PR that bumps the dependency will also test this
release against all supported Ruby versions.

Co-authored-by: ivo.anjo <[email protected]>
**What does this PR do?**

This PR bumps the libdatadog dependency from version 22.0.1.1.0 to
version 23.0.0.1.0.

As this new libdatadog version now compresses profiles using zstd
instead of lz4, I've replaced one with the other on our tests.

**Motivation:**

Adopt the new, better compression for the Ruby profiler.

**Additional Notes:**

Other than the switch from lz4 to zstd on the Ruby profiler, I did
not need to change anything to get a green test suite locally.

**How to test the change?**

I've tested this locally as I'm preparing to release the libdatadog
gem change. I'm going to open this PR as a draft until the libdatadog
gem is up on rubygems.
@ivoanjo ivoanjo force-pushed the ivoanjo/prof-12941-upgrade-libdatadog-23 branch from 12d5c82 to 9d7f579 Compare November 4, 2025 09:48
@pr-commenter
Copy link

pr-commenter bot commented Nov 4, 2025

Benchmarks

Benchmark execution time: 2025-11-04 10:34:23

Comparing candidate commit 4ed723a in PR branch ivoanjo/prof-12941-upgrade-libdatadog-23 with baseline commit 8c1e731 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:profiling - estimated profiler gc per minute (sample 60000 times + serialize result)

  • 🟥 throughput [-1.434op/s; -1.426op/s] or [-40.425%; -40.219%]

scenario:profiling - profiler gc

  • 🟥 throughput [-37865.020op/s; -37191.734op/s] or [-10.904%; -10.710%]

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-3489.295op/s; -3392.172op/s] or [-9.299%; -9.040%]

@ivoanjo ivoanjo marked this pull request as ready for review November 4, 2025 10:22
@ivoanjo ivoanjo requested review from a team as code owners November 4, 2025 10:22
@datadog-datadog-prod-us1
Copy link
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.58% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4ed723a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@ivoanjo ivoanjo merged commit 333959d into master Nov 4, 2025
571 of 587 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/prof-12941-upgrade-libdatadog-23 branch November 4, 2025 16:02
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 4, 2025
anais-raison pushed a commit to DataDog/libdatadog that referenced this pull request Nov 10, 2025
[PROF-12941] Package libdatadog v23.0.0 for Ruby

**What does this PR do?**

This PR includes the changes documented in the "Releasing a new version
to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg

**Motivation:**

Enable Ruby to use libdatadog v23.0.0. In particular, this release
switches the profile serializer to compress data using zstd instead of
lz4.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this change locally with the changes in
DataDog/dd-trace-rb#5020 and was able to get
a green test suite run for Ruby.

As a reminder, new libdatadog releases don't get automatically picked up
by dd-trace-rb, so the PR that bumps the dependency will also test this
release against all supported Ruby versions.

Co-authored-by: ivo.anjo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants