-
Notifications
You must be signed in to change notification settings - Fork 399
[PROF-12941] Upgrade libdatadog dependency to version 23.0.0 #5020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-11-03 18:06:47 UTC |
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v23.0.0. In particular, this release switches the profile serializer to compress data using zstd instead of lz4. **Additional Notes:** N/A **How to test the change?** I've tested this change locally with the changes in DataDog/dd-trace-rb#5020 and was able to get a green test suite run for Ruby. As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the dependency will also test this release against all supported Ruby versions.
[PROF-12941] Package libdatadog v23.0.0 for Ruby **What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v23.0.0. In particular, this release switches the profile serializer to compress data using zstd instead of lz4. **Additional Notes:** N/A **How to test the change?** I've tested this change locally with the changes in DataDog/dd-trace-rb#5020 and was able to get a green test suite run for Ruby. As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the dependency will also test this release against all supported Ruby versions. Co-authored-by: ivo.anjo <[email protected]>
**What does this PR do?** This PR bumps the libdatadog dependency from version 22.0.1.1.0 to version 23.0.0.1.0. As this new libdatadog version now compresses profiles using zstd instead of lz4, I've replaced one with the other on our tests. **Motivation:** Adopt the new, better compression for the Ruby profiler. **Additional Notes:** Other than the switch from lz4 to zstd on the Ruby profiler, I did not need to change anything to get a green test suite locally. **How to test the change?** I've tested this locally as I'm preparing to release the libdatadog gem change. I'm going to open this PR as a draft until the libdatadog gem is up on rubygems.
12d5c82 to
9d7f579
Compare
BenchmarksBenchmark execution time: 2025-11-04 10:34:23 Comparing candidate commit 4ed723a in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics. scenario:profiling - estimated profiler gc per minute (sample 60000 times + serialize result)
scenario:profiling - profiler gc
scenario:tracing - Propagation - Trace Context
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 4ed723a | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
[PROF-12941] Package libdatadog v23.0.0 for Ruby **What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v23.0.0. In particular, this release switches the profile serializer to compress data using zstd instead of lz4. **Additional Notes:** N/A **How to test the change?** I've tested this change locally with the changes in DataDog/dd-trace-rb#5020 and was able to get a green test suite run for Ruby. As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the dependency will also test this release against all supported Ruby versions. Co-authored-by: ivo.anjo <[email protected]>
PROF-12959
What does this PR do?
This PR bumps the libdatadog dependency from version 22.0.1.1.0 to version 23.0.0.1.0.
As this new libdatadog version now compresses profiles using zstd instead of lz4, I've replaced one with the other on our tests.
Motivation:
Adopt the new, better compression for the Ruby profiler.
Change log entry
Yes. Upgrade libdatadog dependency to version 23.0.0
Additional Notes:
Other than the switch from lz4 to zstd on the Ruby profiler, I did not need to change anything to get a green test suite locally.
How to test the change?
I've tested this locally as I'm preparing to release the libdatadog gem change. I'm going to open this PR as a draft until the libdatadog gem is up on rubygems.Update: Libdatadog v23.0.0.1.0 is on rubygems.org, this PR is ready for review!