Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Nov 13, 2025

What does this PR do?
It adds Remote Config capabilities for AppSec Custom Data Classification.

Motivation:
We want to add support for processor overrides and custom data scanners, which were added in libddwaf 1.28.0.

Change log entry
Yes. AppSec: Add support for processor overrides and custom data scanners.

Additional Notes:
APPSEC-59948

How to test the change?
CI and system tests.

@y9v y9v self-assigned this Nov 13, 2025
@y9v y9v requested review from a team as code owners November 13, 2025 14:22
@github-actions github-actions bot added the appsec Application Security monitoring product label Nov 13, 2025
@github-actions
Copy link

Typing analysis

Note: Ignored files are excluded from the next sections.

steep:ignore comments

This PR introduces 2 steep:ignore comments, and clears 2 steep:ignore comments.

steep:ignore comments (+2-2)Introduced:
lib/datadog/appsec/remote.rb:90
lib/datadog/appsec/remote.rb:92
Cleared:
lib/datadog/appsec/remote.rb:84
lib/datadog/appsec/remote.rb:86

Untyped methods

This PR introduces 1 partially typed method, and clears 1 partially typed method.

Partially typed methods (+1-1)Introduced:
sig/datadog/appsec/remote.rbs:64
└── def self.parse_content: (Datadog::Core::Remote::Configuration::Content content) -> ::Hash[::String, untyped]
Cleared:
sig/datadog/appsec/remote.rbs:60
└── def self.parse_content: (Datadog::Core::Remote::Configuration::Content content) -> ::Hash[::String, untyped]

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2025

Benchmarks

Benchmark execution time: 2025-11-13 14:38:01

Comparing candidate commit c6d2501 in PR branch appsec-add-custom-data-classification-capabilities with baseline commit e4ed440 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@datadog-official
Copy link

datadog-official bot commented Nov 13, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 98.53% (-0.05%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c6d2501 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@y9v y9v merged commit 3b63de8 into master Nov 13, 2025
557 of 558 checks passed
@y9v y9v deleted the appsec-add-custom-data-classification-capabilities branch November 13, 2025 16:57
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants