WIP: Magnet module #3921
Open
WIP: Magnet module #3921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CoronelBuendia
changed the base branch from
develop
to
feature/new_magnet_module
CoronelBuendia
changed the base branch from
feature/new_magnet_module
to
develop
CoronelBuendia
changed the base branch from
develop
to
feature/new_magnet_module
CoronelBuendia
force-pushed
the
ivanmaione/magnet_module
branch
from
12c155f to
e0ec460
Compare
* start reversing material changes * reverse material * reverse material * reverse material * reverse mixture * add dependency * add dependency * strand purge * case purge * conductor purge * remove materials json * start on examples * other example purge * update dep branch * some progress ironing out * use is_superconductor * start mat prop comparison * strand props * fix strand Cp * pause * check cable props * Cp not right * match Cp mixture * print test * time func * switch youngs modulus * switch youngs modulus case * typo * clean up * fix other example * start reducing number of OperationalConditions * strand OperationalConditions * case OperationalConditions * conductor OperationalConditions * cable OperationalConditions * OperationalConditions full runthrough * change debug msg to append * fix example * add convergence print * add convergence print * add conv messages for dev * fix tests (except for matproplib error) * op_cond * fix remaining tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #138
Description
This pull request introduces the foundational architecture for modeling superconducting magnet components within the bluemira framework. It follows a bottom-up (micro to macro) design approach, beginning at the strand level and extending up to complete coil case configurations.
The implementation includes core abstractions and physical behavior for:
This structure supports future extensions toward full electromagnetic, thermal, and mechanical simulations of magnet systems.
A complete example has been provided to show the use of the magnet module.
Key Features
Still missing...
Interface Changes
Some minor modifications have been made to materials in order to allow the definition of materials properties that depends on more that one parameter.
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build