Skip to content

Conversation

@je-cook
Copy link
Contributor

@je-cook je-cook commented Nov 17, 2025

Description

Add a dagmc solver to allow for continuous workflow mechanics

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added the neutronics Tasks relating to the neutronics module label Nov 17, 2025
@je-cook je-cook force-pushed the je-cook/dagmc_solver branch from 4042462 to 3ab24cd Compare November 17, 2025 14:18
@CoronelBuendia CoronelBuendia force-pushed the matti/je-cook/process_develop_EUDEMO_LAR branch from d1ff474 to 674a0ac Compare November 17, 2025 18:08
@je-cook je-cook force-pushed the matti/je-cook/process_develop_EUDEMO_LAR branch from 05afa54 to 6207a2f Compare November 18, 2025 08:40
Base automatically changed from matti/je-cook/process_develop_EUDEMO_LAR to develop November 18, 2025 15:53
@je-cook je-cook force-pushed the je-cook/dagmc_solver branch from 3ab24cd to e1f7c13 Compare November 18, 2025 15:58
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 39.65517% with 175 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.45%. Comparing base (b45bfc3) to head (4c40212).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/codes/openmc/solver.py 42.44% 99 Missing ⚠️
bluemira/codes/openmc/output.py 42.46% 42 Missing ⚠️
bluemira/utilities/tools.py 15.00% 17 Missing ⚠️
bluemira/materials/cache.py 11.11% 8 Missing ⚠️
bluemira/codes/openmc/tallying.py 22.22% 7 Missing ⚠️
bluemira/base/builder.py 0.00% 1 Missing ⚠️
bluemira/base/reactor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4150      +/-   ##
===========================================
- Coverage    78.83%   77.45%   -1.38%     
===========================================
  Files          244      244              
  Lines        29276    29418     +142     
===========================================
- Hits         23080    22787     -293     
- Misses        6196     6631     +435     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook je-cook force-pushed the je-cook/dagmc_solver branch 2 times, most recently from b74807d to 0243b1a Compare November 19, 2025 16:04
je-cook and others added 14 commits November 20, 2025 14:45
* fix upper port height

* P_fus_DT and e_mult

* ruff stuff

* fix total heating and pass in pfus

* Created the correct tally for total power.

* Fixed a duplicate name

* typo correction

* Total power is now consistent with what you get when adding up vacuum vessel power + blanket power + divertor power.

* Added the appropriate NWL tallies (#4040)

* Renamed the Setup, Run, and Teardown classes to something more specific.

* Changed the tallies to reflect the NWL properly.

* Add comments/renamed functions/added arguments to make the code more readable.

* Includes the previously-missed cells in the total power tallies now.

* Bug fix

* Added comment to clarify flux tally's 'mean' is actually volume integrated.

* Added tallies and calculations to get the damage values in DPA/FPY as well.

* Removed all traces of the word neutron wall load/NWL because its definition is too ambiguous/not useful.

* removed the calculation about fw heating as well as we aren't using it. (Can be undone if necessary).

* removed unused function

---------

Co-authored-by: matti <[email protected]>

* rebase pain

* omg no deliberate nans

* clean up diagnostic printing

* remove duplicate function

* ruff

* avoid pandas warnings

* ruff

* change DPACoefficients into function

* use

* typing

---------

Co-authored-by: Matti <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

neutronics Tasks relating to the neutronics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants