Skip to content

Conversation

@je-cook
Copy link
Contributor

@je-cook je-cook commented Dec 1, 2025

Linked Issues

Closes #3989

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook requested a review from a team as a code owner December 1, 2025 09:00
@je-cook je-cook added the geometry Tasks relating to the geometry module label Dec 1, 2025
@je-cook je-cook force-pushed the je-cook/no_offset_fallback branch from 3c532f4 to 16ca04b Compare December 1, 2025 09:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.98%. Comparing base (6632945) to head (16ca04b).

Files with missing lines Patch % Lines
bluemira/geometry/tools.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4166      +/-   ##
===========================================
- Coverage    78.98%   78.98%   -0.01%     
===========================================
  Files          244      244              
  Lines        29301    29303       +2     
===========================================
+ Hits         23143    23144       +1     
- Misses        6158     6159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (1)

On collect

  • /home/runner/work/bluemira/bluemira/bluemira/codes/openmc/solver.py:60: DeprecationWarning: In 3.13 the default auto()/generate_next_value will require all values to be sortable and support adding +1 and the value returned will be the largest value in the enum incremented by 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

geometry Tasks relating to the geometry module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flag to prevent discretised offset

3 participants