Skip to content

✨ Allow for offset fallback to be disabled #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
je-cook wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

✨ Allow for offset fallback to be disabled #4166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bluemira/geometry/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@
try:
return func(*args, **kwargs)
except exception:
if not kwargs.get("allow_fallback", True):
raise
bluemira_warn(
f"{func.__name__} failed, falling back to {fallback_func.__name__}."
)
Expand Down Expand Up @@ -599,6 +601,7 @@
closed: bool = False,
start_tangent: Iterable | None = None,
end_tangent: Iterable | None = None,
allow_fallback: bool = True, # noqa: ARG001,

Check warning on line 604 in bluemira/geometry/tools.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Fix the syntax of this issue suppression comment. 


See more on https://sonarcloud.io/project/issues?id=Fusion-Power-Plant-Framework_bluemira&issues=AZrZJXSKrpXy7-sAXgBe&open=AZrZJXSKrpXy7-sAXgBe&pullRequest=4166
) -> BluemiraWire:
"""
Make a bspline from a set of points.
Expand Down Expand Up @@ -904,6 +907,7 @@
fallback_method: str = "square", # noqa: ARG001
byedges: bool = True, # noqa: ARG001
ndiscr: int = 400, # noqa: ARG001
allow_fallback: bool = True, # noqa: ARG001
**fallback_kwargs, # noqa: ARG001
) -> BluemiraWire:
"""
Expand Down
Loading