feat: move audio route manager inside SDK #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/react-native-sdk/src/components/Call/CallContent/CallContent.tsx # sample-apps/react-native/dogfood/ios/Podfile.lock
# Conflicts: # sample-apps/react-native/dogfood/ios/Podfile.lock
# Conflicts: # sample-apps/react-native/dogfood/ios/Podfile.lock
santhoshvai
commented
Sep 12, 2025
Member
Author
There was a problem hiding this comment.
no more objective C code basically, this file is only a mapper for swift here on
santhoshvai
commented
Sep 12, 2025
Member
Author
There was a problem hiding this comment.
not relevant to this PR, but this change is for video dimensions for livestream from #1882
santhoshvai
commented
Sep 15, 2025
Member
Author
There was a problem hiding this comment.
unrelevant to this PR, but i found this small optimisation while doing webrtc snapsots myself
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the audio route manager functionality inside the SDK by introducing a new StreamInCallManager that handles audio routing, device selection, and system-wide audio controls. This replaces the dependency on the external react-native-incall-manager library with native implementations for both iOS and Android platforms.
- Introduces
StreamInCallManagerwith support for audio output device selection and system audio muting/unmuting - Removes dependency on
react-native-incall-managerlibrary across all sample apps and the main SDK - Adds native Android and iOS implementations for comprehensive audio management
Reviewed Changes
Copilot reviewed 40 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/react-native-sdk/src/StreamInCallManager/index.ts |
New TypeScript interface for the native audio manager with device selection and muting capabilities |
packages/react-native-sdk/ios/StreamInCallManager.swift |
Native iOS implementation handling audio session configuration and device routing |
packages/react-native-sdk/android/src/main/java/com/streamvideo/reactnative/callmanager/StreamInCallManagerModule.kt |
Native Android module providing audio device management and routing functionality |
sample-apps/react-native/dogfood/src/components/CallControlls/MoreActionsButton.tsx |
Updates to use new audio route picker functionality |
packages/react-native-sdk/src/components/Livestream/LivestreamControls/ViewerLivestreamControls.tsx |
Migration from react-native-incall-manager to StreamInCallManager for audio output control |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sample-apps/react-native/dogfood/src/screens/LiveStream/ViewLiveStream.tsx
Show resolved
Hide resolved
packages/react-native-sdk/src/components/Livestream/ViewerLivestream/ViewerLivestream.tsx
Show resolved
Hide resolved
packages/react-native-sdk/src/components/Call/CallContent/CallContent.tsx
Show resolved
Hide resolved
# Conflicts: # packages/noise-cancellation-react-native/android/build.gradle # packages/react-native-sdk/ios/StreamVideoReactNative.h # packages/react-native-sdk/ios/StreamVideoReactNative.m # sample-apps/react-native/dogfood/ios/Podfile.lock # sample-apps/react-native/expo-video-sample/package.json # yarn.lock
oliverlaz
approved these changes
Oct 7, 2025
oliverlaz
added a commit
that referenced
this pull request
Oct 8, 2025
Follow-up to #1840. Fixes a compatibility issue with RN 0.80+.
oliverlaz
added a commit
that referenced
this pull request
Oct 27, 2025
) When we migrated away from InCallManager (#1840) to our in-house `callManager`, we didn't port the Wake Lock on iOS and proximity sensing on both Android and iOS. This PR closes that gap. 🎫 Ticket: https://linear.app/stream/issue/RN-291/screen-auto-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
fixes: #1829
📑 Docs: https://github.com/GetStream/docs-content/pull/603