fix: viewer livestream muting issue in SDK #1882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/react-native-sdk/src/components/Livestream/LivestreamControls/ViewerLivestreamControls.tsx
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes audio muting issues in the livestream viewer by changing how audio control works and improves video dimension tracking for better layout handling.
- Audio muting now controls the volume of the dominant speaker's audio track directly instead of using InCallManager for speakerphone control
- Video dimension tracking is improved using a new hook-based approach that tracks dimensions per participant and track type
- Sample app is simplified by removing manual call object creation and management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ViewLiveStream.tsx | Simplifies component by removing manual call creation and directly rendering LivestreamPlayer |
| LivestreamLayout.tsx | Replaces stats-based dimension tracking with hook-based approach and adds objectFit to all VideoRenderer instances |
| ViewerLivestreamControls.tsx | Changes audio muting from InCallManager speakerphone control to direct audio track volume manipulation |
...s/react-native-sdk/src/components/Livestream/LivestreamControls/ViewerLivestreamControls.tsx
Outdated
Show resolved
Hide resolved
...s/react-native-sdk/src/components/Livestream/LivestreamControls/ViewerLivestreamControls.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-sdk/src/components/Livestream/LivestreamLayout/LivestreamLayout.tsx
Show resolved
Hide resolved
kristian-mkd
approved these changes
Aug 8, 2025
oliverlaz
reviewed
Aug 11, 2025
Comment on lines
+110
to
+119
| const audioTrack = dominantSpeaker?.audioStream?.getAudioTracks?.()[0]; | ||
| const shouldMute = !isMuted; | ||
| if (shouldMute) { | ||
| // @ts-expect-error - _setVolume is a private method of MediaStreamTrack in rn-webrtc | ||
| audioTrack?._setVolume(0); | ||
| } else { | ||
| // @ts-expect-error -_setVolume is a private method of MediaStreamTrack in rn-webrtc | ||
| audioTrack?._setVolume(0.75); | ||
| } | ||
| setIsMuted(shouldMute); |
Member
There was a problem hiding this comment.
This assumes that there is only one presenter. In case there are multiple, the behavior of this code is non-deterministic.
For example:
- At the moment of mute, A was the dominant speaker
- At the moment of unmute, B is the dominant speaker
In this case, A will stay forever muted, and B will always be audible.
We need to either:
- Mute audio on system level
- Mute all available audio tracks, individually
Member
Author
|
this fix will be included in #1840 as new audio manager is required for system level mute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
This pull request updates the livestream viewer and layout components to improve audio muting and video dimension handling, while simplifying the way livestream calls are rendered in the sample app. The most important changes are grouped below:
Audio Muting Logic Improvements:
ViewerLivestreamControlscomponent now mutes/unmutes the dominant speaker's audio by adjusting the audio track volume directly, instead of toggling the speakerphone viaInCallManager. This provides more precise control over audio muting in livestreams. [1] [2] [3]Livestream Layout and Video Dimension Handling:
LivestreamLayoutcomponent now uses a newVideoTrackDimensionsRenderLessComponentthat leverages theuseTrackDimensionshook to accurately track and update video dimensions for both the presenter (during screen share) and the current speaker. This replaces the previous approach based on call stats reports. [1] [2] [3] [4]objectFitproperty onVideoRendererhas been simplified, and the property is now consistently passed for both presenter and current speaker video tracks. [1] [2]Sample App Simplification:
ViewLiveStreamChildrencomponent no longer manually creates and manages the call object, and instead directly renders theLivestreamPlayercomponent, reducing complexity.