feat(expr): support avg functions on vector #7146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
docs-not-required
Contributor
|
Is it still in draft? @Standing-Man |
Contributor
Author
Yes, this PR currently only implements the |
Contributor
Yes. And convert it back when it's ready. Thanks! |
Standing-Man
commented
Oct 28, 2025
Contributor
Author
|
Hi @killme2008 and @evenyag, I’ve fixed the SQLness test issue, PTAL. |
evenyag
reviewed
Oct 29, 2025
Standing-Man
force-pushed
the
vector-avg
branch
from
7f8496b to
59c6836
Compare
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
force-pushed
the
vector-avg
branch
from
c98f37d to
02ba91d
Compare
evenyag
reviewed
Nov 3, 2025
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
force-pushed
the
vector-avg
branch
from
a5d696f to
d1b7080
Compare
evenyag
approved these changes
Nov 7, 2025
Contributor
|
I merged the main branch to see if CI can pass. |
Contributor
Author
|
Thanks to all the reviewers for your valuable suggestions! |
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
Nov 11, 2025
* feat(expr): support vec_elem_avg function Signed-off-by: Alan Tang <[email protected]> * feat: support vec_avg function Signed-off-by: Alan Tang <[email protected]> * test: add more query test for avg aggregator Signed-off-by: Alan Tang <[email protected]> * fix: fix the merge batch mode Signed-off-by: Alan Tang <[email protected]> * refactor: use sum and count as state for avg function Signed-off-by: Alan Tang <[email protected]> * refactor: refactor merge batch mode for avg function Signed-off-by: Alan Tang <[email protected]> * feat: add additional vector restrictions for validation Signed-off-by: Alan Tang <[email protected]> --------- Signed-off-by: Alan Tang <[email protected]> Co-authored-by: Yingwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
vec_elem_avgvec_avgPR Checklist
Please convert it to a draft if some of the following conditions are not met.