Skip to content

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 9, 2025

What this PR does / why we need it:

This PR allows for listing the available dataset types.

This PR builds on this earlier PR that introduces dataset types:

I figured we could merge this new PR into the older one and test it all once. Or we can test separately. Whatever works!

Which issue(s) this PR closes:

Related Dataverse PRs:

See above. Also, this one:

Special notes for your reviewer:

I didn't add docs for either PR yet. I'm happy to, once we decide if we want to combine them or not.

Also, in VS Code, I'm getting an error in src/index.ts. I'll leave a comment under "files changed" about it.

I modeled this PR off the one for licenses:

Suggestions on how to test this:

Run the tests.

Is there a release notes update needed for this change?:

Yes, something like this:

"You can list available dataset types."

Additional documentation:

None.

Comment on lines +1 to +3
import { ApiConfig } from '../../../src'
import { getAvailableDatasetTypes } from '../../../src/datasetTypes'
import { DatasetType } from '../../../src/datasetTypes/domain/models/DatasetType'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed at

import { ApiConfig, getAvailableStandardLicenses, License } from '../../../src'
that the equivalent three import statements above are on a single line.

I'm not sure why this isn't working for me but perhaps it's related to the error I'm seeing in src/index.ts in VS Code:

Screenshot 2025-09-09 at 1 55 33 PM

I'm not sure what's going on. 🤷

@pdurbin
Copy link
Member Author

pdurbin commented Sep 10, 2025

Closing in favor of this PR:

For thoughts on what order PRs would be better made in: #360 (comment)

@pdurbin pdurbin closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants