-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: cp-13.12.0 only use build feature flag for sidepanel #38408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+160
−153
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
8faf9bb
feat: only use remote FF for sidepanel
NidhiKJha a41e775
lint fix
NidhiKJha 29dcfa1
restored check for firefox
NidhiKJha 41ee047
updated manifest
NidhiKJha bcf1659
Merge branch 'main' into sidepanel-remote-flag
NidhiKJha 97231f5
updated test
NidhiKJha f00030e
Merge branch 'main' into sidepanel-remote-flag
NidhiKJha 5f662b7
updated console error
NidhiKJha 733a22b
e2e fix
NidhiKJha e3f10e8
updated helpers
NidhiKJha faf9891
updated helpers
NidhiKJha d390cd2
Merge branch 'main' into sidepanel-remote-flag
NidhiKJha 8c865ce
helper update
NidhiKJha cd6e517
updated sidepanel
NidhiKJha 956cadb
updated sidepanel
NidhiKJha 3e29061
Merge branch 'main' into sidepanel-remote-flag
NidhiKJha a4980cb
sidepanel fence
NidhiKJha c286e1e
Merge branch 'main' into sidepanel-remote-flag
ameliejyc fa9d999
fix: e2e tests by adding sidepanel env flag
ameliejyc 920ea47
chore: update sidepanel env check conditions
ameliejyc e692d9a
chore: fix isSidePanelEnabled calls
ameliejyc 056ccbf
chore: fix isSidePanelEnabled calls again
ameliejyc f78abd4
chore: bring back useSidePanelEnabled
ameliejyc 67c4541
fix: onboarding e2e tests
ameliejyc b14a9d5
chore: add debug log
ameliejyc 11255c1
fix: Browser import
ameliejyc 2fa16aa
chore: make hasSidepanel check more specific
ameliejyc bb8b7e3
chore: fix lint
ameliejyc 6f558d9
Merge branch 'main' into sidepanel-remote-flag
ameliejyc 4916d85
fix: problematic browser import
ameliejyc 346dad3
fix: vault encryptor test
ameliejyc 23c0f5d
Merge branch 'main' into sidepanel-remote-flag
hjetpoluru 4b50616
chore: revert back isSidePanelEnabled code
ameliejyc cab7484
chore: remove unused import
ameliejyc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.