feat: cp-13.12.0 only use build feature flag for sidepanel #38408
+160
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
changed the title
NidhiKJha
changed the title
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +1 -1)
🧪 @MetaMask/qa (2 files, +46 -19)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
AndyMBridges
previously approved these changes
Nov 28, 2025
Member
Author
|
@Gudahtt should we remove https://github.com/MetaMask/metamask-extension/blob/main/app/manifest/v3/_base.json#L92 change as well. Since we are removing |
ui/pages/onboarding-flow/creation-successful/creation-successful.tsx
Outdated
Show resolved
Hide resolved
Member
|
Yes certainly, removing the permission would be better if we're not using it |
n3ps
previously approved these changes
Nov 28, 2025
Collaborator
Builds ready [41ee047]
UI Startup Metrics (1175 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [bcf1659]
UI Startup Metrics (1247 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [6f558d9]
UI Startup Metrics (1324 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [4916d85]
UI Startup Metrics (1201 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [346dad3]
UI Startup Metrics (1354 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [4b50616]
UI Startup Metrics (1307 ± 126 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
| await driver.driver.get(`${driver.extensionUrl}/home.html`); | ||
|
|
||
| // Wait for the home page to fully load | ||
| await driver.waitForSelector('[data-testid="account-menu-icon"]'); |
There was a problem hiding this comment.
Bug: Sidepanel handling inconsistent with flag check helper
The handleSidepanelPostOnboarding function now runs sidepanel-specific navigation unconditionally for Chrome browsers, but it no longer checks the IS_SIDEPANEL environment variable. This is inconsistent with the newly created isSidePanelEnabled() helper which checks both SELENIUM_BROWSER === 'chrome' AND IS_SIDEPANEL === 'true'. If tests are run with IS_SIDEPANEL unset or false, isSidePanelEnabled() returns false while handleSidepanelPostOnboarding still performs sidepanel-specific delays and navigation, causing inconsistent behavior.
Contributor
There was a problem hiding this comment.
I think this is a valid comment though I think also it was the isSidePanelEnabled() check here that was breaking the vault encryption tests
hjetpoluru
approved these changes
Dec 2, 2025
Contributor
hjetpoluru
left a comment
hjetpoluru
left a comment
There was a problem hiding this comment.
QA related files LGTM
Collaborator
Builds ready [cab7484]
UI Startup Metrics (1257 ± 133 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
n3ps
approved these changes
Dec 2, 2025
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to ensure sidepanel is rendered based on build FF:
IS_SIDEPANELIt also removes the sidepanel context menu
Set the
IS_SIDEPANELto true for all buildsDescription
Changelog
CHANGELOG entry:null
Related issues
Fixes: context issue
FF update
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Enable sidepanel via build-time IS_SIDEPANEL only, remove sidepanel context menu, set flag true across builds, and adjust background/UI/tests accordingly.
process.env.IS_SIDEPANEL(remove LaunchDarkly dependency) viauseSidePanelEnabled.IS_SIDEPANEL: truefor all build types and E2E workflow.app/scripts/lib/sidepanel-context-menu.ts, related imports/calls inbackground.js).contextMenuspermission fromapp/manifest/v3/_base.json(retainsidePanel).GlobalMenuuses build flag for sidepanel availability; logic unchanged otherwise.isSidePanelEnabledhelper and integrate into specs to skip or alter assertions (e.g., toasts, request counts) when sidepanel is active.home.htmlpost-completion on Chrome; add waits/switching by URL.Written by Cursor Bugbot for commit cab7484. This will update automatically on new commits. Configure here.