feat: cp-13.12.0 only use build feature flag for sidepanel

app/manifest/v3/_base.json

@@ -88,8 +88,7 @@
     "webRequest",
     "offscreen",
     "identity",
-    "sidePanel",
-    "contextMenus"
+    "sidePanel"
   ],
   "sandbox": {
     "pages": ["snaps/index.html"]

app/scripts/background.js

@@ -55,7 +55,6 @@ import {
   CorruptionHandler,
   hasVault,
 } from './lib/state-corruption/state-corruption-recovery';
-import { initSidePanelContextMenu } from './lib/sidepanel-context-menu';
 import {
   backedUpStateKeys,
   PersistenceManager,
@@ -183,7 +182,6 @@ const PHISHING_WARNING_PAGE_TIMEOUT = ONE_SECOND_IN_MILLISECONDS;
 
 lazyListener.once('runtime', 'onInstalled').then((details) => {
   handleOnInstalled(details);
-  handleSidePanelContextMenu();
 });
 
 /**
@@ -1663,15 +1661,6 @@ function onInstall() {
   }
 }
 
-/**
- * Handles the onInstalled event for sidepanel context menu creation.
- * This is registered via lazyListener to catch the event at module load time.
- */
-async function handleSidePanelContextMenu() {
-  await isInitialized;
-  await initSidePanelContextMenu(controller);
-}
-
 /**
  * Trigger actions that should happen only when an update is available
  */
@@ -1749,18 +1738,6 @@ const initSidePanelBehavior = async () => {
         openPanelOnActionClick: useSidePanelAsDefault,
       });
     }
-
-    // Setup remote feature flag listener to update sidepanel preferences
-    controller?.controllerMessenger?.subscribe(
-      'RemoteFeatureFlagController:stateChange',
-      (state) => {
-        const extensionUxSidepanel =
-          state?.remoteFeatureFlags?.extensionUxSidepanel;
-        if (extensionUxSidepanel === false) {
-          controller?.preferencesController?.setUseSidePanelAsDefault(false);
-        }
-      },
-    );
   } catch (error) {
     console.error('Error setting side panel behavior:', error);
   }

builds.yml

@@ -69,7 +69,7 @@ buildTypes:
       - REJECT_INVALID_SNAPS_PLATFORM_VERSION: true
       - IFRAME_EXECUTION_ENVIRONMENT_URL: https://execution.metamask.io/iframe/10.2.3/index.html
       - ACCOUNT_SNAPS_DIRECTORY_URL: https://snaps.metamask.io/account-management
-      - IS_SIDEPANEL: false
+      - IS_SIDEPANEL: true
       - EXTENSION_UX_PNA25: true
       # for seedless onboarding (social login)
       - GOOGLE_BETA_CLIENT_ID
@@ -140,7 +140,7 @@ buildTypes:
       - SEGMENT_WRITE_KEY_REF: SEGMENT_FLASK_WRITE_KEY
       - ACCOUNT_SNAPS_DIRECTORY_URL: https://metamask.github.io/snaps-directory-staging/main/account-management
       - EIP_4337_ENTRYPOINT: '0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789'
-      - IS_SIDEPANEL: false
+      - IS_SIDEPANEL: true
       - EXTENSION_UX_PNA25: true
       # for seedless onboarding (social login)
       - GOOGLE_FLASK_CLIENT_ID

test/e2e/page-objects/flows/onboarding.flow.ts

@@ -25,10 +25,9 @@ import TermsOfUseUpdateModal from '../pages/dialog/terms-of-use-update-modal';
 export const handleSidepanelPostOnboarding = async (
   driver: Driver,
 ): Promise<void> => {
-  // Check if sidepanel is enabled via build configuration
   // AND we're not running on Firefox (which doesn't support sidepanel)
   const isSidepanelEnabled =
-    process.env.IS_SIDEPANEL === 'true' &&
+    process.env.IS_SIDEPANEL &&
     process.env.SELENIUM_BROWSER !== Browser.FIREFOX;
 
   if (isSidepanelEnabled) {

ui/components/multichain/global-menu/global-menu.test.tsx

@@ -9,7 +9,6 @@ import {
 } from '../../../helpers/constants/routes';
 import { isGatorPermissionsRevocationFeatureEnabled } from '../../../../shared/modules/environment';
 import { getBrowserName } from '../../../../shared/modules/browser-runtime.utils';
-import { useSidePanelEnabled } from '../../../hooks/useSidePanelEnabled';
 import {
   ENVIRONMENT_TYPE_POPUP,
   PLATFORM_FIREFOX,
@@ -58,10 +57,6 @@ jest.mock('../../../store/actions', () => ({
 
 jest.mock('../../../../shared/modules/environment');
 
-jest.mock('../../../hooks/useSidePanelEnabled', () => ({
-  useSidePanelEnabled: jest.fn(() => false),
-}));
-
 jest.mock('../../../../app/scripts/lib/util', () => ({
   ...jest.requireActual('../../../../app/scripts/lib/util'),
   getEnvironmentType: jest.fn(),
@@ -127,7 +122,6 @@ describe('Global Menu', () => {
     );
     jest.mocked(getBrowserName).mockReturnValue(PLATFORM_FIREFOX);
     jest.mocked(getEnvironmentType).mockReturnValue(ENVIRONMENT_TYPE_POPUP);
-    jest.mocked(useSidePanelEnabled).mockReturnValue(true);
 
     // @ts-expect-error mocking platform
     global.platform = {

ui/components/multichain/global-menu/global-menu.tsx

@@ -25,7 +25,6 @@ import {
 } from '../../../store/actions';
 import { isGatorPermissionsRevocationFeatureEnabled } from '../../../../shared/modules/environment';
 import { useI18nContext } from '../../../hooks/useI18nContext';
-import { useSidePanelEnabled } from '../../../hooks/useSidePanelEnabled';
 import {
   selectIsMetamaskNotificationsEnabled,
   selectIsMetamaskNotificationsFeatureSeen,
@@ -169,7 +168,7 @@ export const GlobalMenu = ({
   const isSidePanelDefault = preferences?.useSidePanelAsDefault ?? false;
 
   // Check if sidepanel feature is enabled (both build flag and LaunchDarkly flag)
-  const isSidePanelEnabled = useSidePanelEnabled();
+  const isSidePanelEnabled = process.env.IS_SIDEPANEL;
 
   const showPriorityTag = useMemo(
     () =>

ui/pages/onboarding-flow/creation-successful/creation-successful.js

@@ -53,7 +53,6 @@ import {
   setUseSidePanelAsDefault,
 } from '../../../store/actions';
 import { LottieAnimation } from '../../../components/component-library/lottie-animation';
-import { useSidePanelEnabled } from '../../../hooks/useSidePanelEnabled';
 import WalletReadyAnimation from './wallet-ready-animation';
 
 export default function CreationSuccessful() {
@@ -67,7 +66,7 @@ export default function CreationSuccessful() {
   );
   const trackEvent = useContext(MetaMetricsContext);
   const firstTimeFlowType = useSelector(getFirstTimeFlowType);
-  const isSidePanelEnabled = useSidePanelEnabled();
+  const isSidePanelEnabled = process.env.IS_SIDEPANEL;
 
   const learnMoreLink =
     'https://support.metamask.io/stay-safe/safety-in-web3/basic-safety-and-security-tips-for-metamask/';

ui/pages/onboarding-flow/pin-extension/pin-extension.js

@@ -44,7 +44,6 @@ import {
 } from '../../../../shared/constants/metametrics';
 import { FirstTimeFlowType } from '../../../../shared/constants/onboarding';
 import { getBrowserName } from '../../../../shared/modules/browser-runtime.utils';
-import { useSidePanelEnabled } from '../../../hooks/useSidePanelEnabled';
 
 export default function OnboardingPinExtension() {
   const t = useI18nContext();
@@ -54,7 +53,6 @@ export default function OnboardingPinExtension() {
   const trackEvent = useContext(MetaMetricsContext);
   const firstTimeFlowType = useSelector(getFirstTimeFlowType);
   const currentKeyring = useSelector(getCurrentKeyring);
-  const isSidePanelEnabled = useSidePanelEnabled();
 
   const externalServicesOnboardingToggleState = useSelector(
     getExternalServicesOnboardingToggleState,
@@ -76,7 +74,7 @@ export default function OnboardingPinExtension() {
     });
 
     // Side Panel - only if feature flag is enabled and not in test mode
-    if (isSidePanelEnabled) {
+    if (process.env.IS_SIDEPANEL) {
       try {
         if (browser?.sidePanel?.open) {
           const tabs = await browser.tabs.query({

ui/pages/onboarding-flow/pin-extension/pin-extension.test.js

@@ -39,11 +39,6 @@ jest.mock('react-router-dom-v5-compat', () => {
   };
 });
 
-// Mock the useSidePanelEnabled hook to control sidepanel feature flag
-jest.mock('../../../hooks/useSidePanelEnabled', () => ({
-  useSidePanelEnabled: jest.fn(() => false),
-}));
-
 describe('Creation Successful Onboarding View', () => {
   afterEach(() => {
     jest.clearAllMocks();