[Sessions] Show what historical sessions are currently being used for filtering #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n service and session indicator
davetsay
requested changes
Feb 24, 2025
src/multipleHistoricalSessions/indicator/historicalSessionIndicator.vue
Outdated
Show resolved
Hide resolved
…f 2, made more generic as well
davetsay
approved these changes
Feb 24, 2025
Collaborator
davetsay
left a comment
davetsay
left a comment
There was a problem hiding this comment.
Nice. Super tiny nit. i think you did away with "1 and 2" and its just "1, 2", but you added the "1 and 2" in the jsdoc.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #201
Updated the historical session indicator to show which sessions are currently being used to filter historical requests.
For 1 session:
For more than one session:
Updated the notification that shows when you select a historical session to also show which sessions are currently being used to filter.