Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,27 @@
<span class="angular-w"> Historical Session Filtering Disabled in Config </span>
</span>

<span v-else class="c-indicator__label" style="display: flex; flex-direction: column">
<template v-if="availableSessions.length">
<span v-if="sessionFilter.numbers" class="angular-w">
{{ filteredByMessageString }}
<button @click="openSessionSelector">Change</button>
<button @click="clearAllSessions">Clear</button>
</span>
<span
v-else
class="c-indicator__label"
style="display:flex; flex-direction:column;"
>

<template v-if="availableSessions.length">

<span
v-if="sessionFilter.numbers"
:title="filteredByTitleString"
class="angular-w"
>
{{filteredByMessageString}}
<button @click="openSessionSelector">
Change
</button>
<button @click="clearAllSessions">
Clear
</button>
</span>

<span v-else class="angular-w">
Filter by historical sessions
Expand Down Expand Up @@ -48,64 +62,72 @@
<script>
import HistoricalSessionSelector from '../sessionSelector/historicalSessionSelector.vue';
import SessionService from 'services/session/SessionService';

import { formatNumberSequence } from '../../utils/strings';
export default {
inject: ['openmct', 'table'],
components: {
HistoricalSessionSelector
},
computed: {
filteredByMessageString() {
let sessionOrSessions;

if (this.sessionFilter.numbers.length === 1) {
sessionOrSessions = 'session';
} else {
sessionOrSessions = 'sessions';
}
return `Historical queries filtered by ${this.sessionFilter.numbers.length} ${sessionOrSessions}`;
}
},
data() {
return {
sessionFilter: {},
numFilteredSessions: 8,
availableSessions: [],
showSessionSelector: false,
isRequestingSessions: false,
historicalSessionFilterDisabled: false
};
},
methods: {
setHistoricalSessionFilter(sessions) {
if (sessions) {
this.sessionFilter = sessions;
} else {
this.sessionFilter = {};
}
},
setAvailableSessions(sessions) {
this.isRequestingSessions = false;
this.availableSessions = sessions;
inject: [
'openmct',
'table'
],
components: {
HistoricalSessionSelector
},
openSessionSelector() {
this.showSessionSelector = true;
computed: {
filteredByMessageString() {
let sessionOrSessions;

if (this.sessionFilter.numbers.length === 1) {
sessionOrSessions = `session: ${this.sessionFilter.numbers[0]}`;
} else {
sessionOrSessions = 'sessions';
}
return `Historical queries filtered by ${this.sessionFilter.numbers.length} ${sessionOrSessions}`;
},
filteredByTitleString() {
let sessionNumbers = formatNumberSequence(this.sessionFilter.numbers);
let hostString = this.sessionFilter.host ? `on host ${this.sessionFilter.host} ` : '';

return `Currently filtering ${hostString}by: ${sessionNumbers}`;
}
},
closeSessionSelector() {
this.showSessionSelector = false;
data() {
return {
sessionFilter: {},
numFilteredSessions: 8,
availableSessions: [],
showSessionSelector: false,
isRequestingSessions: false,
historicalSessionFilterDisabled: false
}
},
clearAllSessions() {
this.sessionService.setHistoricalSessionFilter();
methods: {
setHistoricalSessionFilter(sessions) {
if (sessions) {
this.sessionFilter = sessions;
} else {
this.sessionFilter = {};
}
},
setAvailableSessions(sessions) {
this.isRequestingSessions = false;
this.availableSessions = sessions;
},
openSessionSelector() {
this.showSessionSelector = true;
},
closeSessionSelector() {
this.showSessionSelector = false;
},
clearAllSessions() {
this.sessionService.setHistoricalSessionFilter();
},
checkForHistoricalSessions() {
this.isRequestingSessions = true;
this.sessionService.getHistoricalSessions({}).then(this.setAvailableSessions);
}
},
checkForHistoricalSessions() {
this.isRequestingSessions = true;
this.sessionService.getHistoricalSessions({}).then(this.setAvailableSessions);
}
},
mounted() {
this.sessionService = SessionService();
this.historicalSessionFilterDisabled =
this.sessionService.historicalSessionFilterConfig.disable;
mounted() {
this.sessionService = SessionService();
this.historicalSessionFilterDisabled = this.sessionService.historicalSessionFilterConfig.disable;

window.setTimeout(this.checkForHistoricalSessions, 2000);

Expand Down
7 changes: 5 additions & 2 deletions src/services/session/SessionService.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import mcws from 'services/mcws/mcws';
import DatasetCache from 'services/dataset/DatasetCache';
import SessionURLHandler from './SessionURLHandler';
import SessionLocalStorageHander from './SessionLocalStorageHandler';

import { formatNumberSequence } from '../../utils/strings';
const ERROR_PREFIX = 'Error when notifying listener: ';

/**
Expand Down Expand Up @@ -405,7 +405,10 @@ class SessionService {
let notificationString = 'Historical queries not restricted by session.';

if (model) {
notificationString = `Historical queries restricted to ${model.numbers.length} ${model.numbers.length > 1 ? "session's" : 'session'} on ${model.host}.`;
let hostString = model.host ? ` on host ${model.host}.` : '.';
let sessionString = model.numbers.length > 1 ? "session's" : 'session';

notificationString = `Historical queries restricted to ${model.numbers.length} ${sessionString} (${formatNumberSequence(model.numbers)})${hostString}`;
}

this.notificationService.info(notificationString);
Expand Down
46 changes: 45 additions & 1 deletion src/utils/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,48 @@ function snakeCaseToStartCase(str) {
.join(' ');
}

export { snakeCaseToStartCase };
/**
* Formats an array of numbers into a human-readable string, showing ranges with ellipsis
* and individual numbers with commas.
* Examples:
* [1,2,3,4,5] → "1...5"
* [1,2,3,5,7,8,9] → "1...3, 5, 7...9"
* [1,3,5,7] → "1, 3, 5, 7"
* [1,2] → "1, 2"
* @param {Array<number|string>} numbers - Array of numbers to format
* @returns {string} Formatted string representation
*/
function formatNumberSequence(numbers) {
const sortedNumbers = numbers.map(Number).sort((a, b) => a - b);
let result = `${sortedNumbers[0]}`;
let rangeLength = 1;

for (let i = 1; i < sortedNumbers.length; i++) {
const current = sortedNumbers[i];
const prev = sortedNumbers[i - 1];

if (current === prev + 1) {
rangeLength++;
} else {
if (rangeLength > 2) {
result += `...${prev}`;
} else if (rangeLength === 2) {
result += `, ${prev}`;
}

result += `, ${current}`;
rangeLength = 1;
}
}

// Handle the last range if it exists
if (rangeLength > 2) {
result += `...${sortedNumbers[sortedNumbers.length - 1]}`;
} else if (rangeLength === 2) {
result += `, ${sortedNumbers[sortedNumbers.length - 1]}`;
}

return result;
}

export { snakeCaseToStartCase, formatNumberSequence };