Skip to content

Conversation

@davetsay
Copy link
Collaborator

Closes #270

  • install eslint
  • configure to js lint vue files
  • configure to incorporate prettier as a eslint rule

@davetsay davetsay requested a review from jvigliotta February 15, 2025 01:20
@davetsay davetsay changed the base branch from main to topic/219-code-lint February 15, 2025 01:22
console.log('Requirement ID | Test Procedures | Status');
console.log('--- | --- | --- ');
_.each(sortedRequirements, function (requirement) {
var procedureCount = requirement.procedures.length;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even use this file anymore? should we just axe it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably. can create a maintenance ticket to prune unnecessary files

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work. Have a couple questions and one change.

@sonarqubecloud
Copy link

@davetsay davetsay requested a review from jvigliotta February 21, 2025 18:54
@davetsay
Copy link
Collaborator Author

@jvigliotta addressed comments and made a couple more commits that need re-review

Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jvigliotta jvigliotta merged commit 0d09021 into topic/219-code-lint Feb 21, 2025
1 check passed
@jvigliotta jvigliotta deleted the 219/eslint branch February 21, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install and configure eslint

3 participants