Skip to content

Fix q78 problematic value comparison #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Fix q78 problematic value comparison #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77e52e2
Fix q78 problematic value comparison
yinqingh Apr 2, 2025
2aa24da
Fix license header
yinqingh Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions nds/nds_validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env python3
# -*- coding: utf-8 -*-
#
# SPDX-FileCopyrightText: Copyright (c) 2022-2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -179,14 +179,12 @@ def rowEqual(row1, row2, epsilon, is_q78, q78_problematic_col):
problematic_val_row2 = row2.pop(q78_problematic_col-1)
problematic_val_eq = False
# this value could be none in some rows
if all([problematic_val_row1, problematic_val_row2]):
if problematic_val_row1 is not None and problematic_val_row2 is not None:
# this value is rounded to its pencentile: round(ss_qty/(coalesce(ws_qty,0)+coalesce(cs_qty,0)),2)
# so we allow the diff <= 0.01 + default epsilon 0.00001
problematic_val_eq = abs(problematic_val_row1 - problematic_val_row2) <= 0.01001
elif problematic_val_row1 == None and problematic_val_row2 == None:
problematic_val_eq = True
else:
problematic_val_eq = False
problematic_val_eq = problematic_val_row1 is None and problematic_val_row2 is None
return problematic_val_eq and all([compare(lhs, rhs, epsilon) for lhs, rhs in zip(row1, row2)])
else:
return all([compare(lhs, rhs, epsilon) for lhs, rhs in zip(row1, row2)])
Expand Down