Skip to content

Conversation

@Green-D-683
Copy link
Contributor

Description of changes

Added Asus Zenbook Pro ux535

Things done

I've been using NixOS on this laptop for a while now, so I figured my configuration was hopefully stable enough to be upstreamed here for others to use. All values were taken from my config, along with some other values that I've found to cause bugs if set turned off.

I found the contributing docs to be outdated when it came to running the testing python script, it seems to have had major changes made three weeks ago that have changed it's usage. The command: ./tests/run.py --jobs 4 --verbose --nixos-hardware ./. worked for me to test all modules, I couldn't figure out how we're now meant to test only a single module (--jobs 4 is only because I ran out of Memory without a limit, and it ran quickly enough with 4 without using too much, you could probably increase this or just remove it.).

  • [/] Tested the changes in your own NixOS Configuration
  • [/] Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2024

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #1123 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2024

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3827903

mergify bot added a commit that referenced this pull request Oct 19, 2024
@mergify mergify bot merged commit 3827903 into NixOS:master Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants