-
Notifications
You must be signed in to change notification settings - Fork 186
feat(app): add tip rack to DropTipLocation as a new option #19897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
fbc9616
f11e8e2
7c800c3
f6daaed
c18f094
4899176
c9d6c14
0f91274
e916e7b
fdeef61
a886b1e
a508826
4f5d4c9
827786f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ export interface QuickTransferWizardState { | |
| // Note added for liquid classes in Quick Transfer | ||
| path?: PathOption | ||
| changeTip?: ChangeTipOptions | ||
| dropTipLocation?: CutoutConfig | ||
| dropTipLocation?: CutoutConfig | string | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see type comment above |
||
| liquidClassName?: string | ||
| } | ||
| export type PathOption = 'single' | 'multiAspirate' | 'multiDispense' | ||
|
|
@@ -120,7 +120,7 @@ export interface QuickTransferSummaryState { | |
| } | ||
| airGapDispense?: number | ||
| changeTip: ChangeTipOptions | ||
| dropTipLocation: CutoutConfig | ||
| dropTipLocation: CutoutConfig | string | ||
| liquidClassName: string | ||
| conditionAspirate?: number | ||
| disposalVolumeDispenseSettings?: { | ||
|
|
@@ -290,7 +290,7 @@ interface SetChangeTip { | |
| } | ||
| interface SetDropTipLocation { | ||
| type: typeof ACTIONS.SET_DROP_TIP_LOCATION | ||
| location: CutoutConfig | ||
| location: CutoutConfig | string | ||
| } | ||
|
|
||
| interface SetLiquidClassAction { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { TRASH_BIN_ADAPTER_FIXTURE } from '@opentrons/shared-data' | ||
| import { | ||
| DEST_WELL_BLOWOUT_DESTINATION, | ||
| SOURCE_WELL_BLOWOUT_DESTINATION, | ||
| } from '@opentrons/step-generation' | ||
|
|
||
| import type { CutoutConfig } from '@opentrons/shared-data' | ||
| import type { BlowOutLocation } from '../types' | ||
|
|
||
| export const convertBlowoutLocation = ( | ||
| location: string | undefined, | ||
| dropTipLocation: CutoutConfig | string | ||
| ): BlowOutLocation | undefined => { | ||
| if (location == null) return undefined | ||
|
|
||
| switch (location) { | ||
| case 'source': | ||
| return SOURCE_WELL_BLOWOUT_DESTINATION | ||
| case 'destination': | ||
| return DEST_WELL_BLOWOUT_DESTINATION | ||
| case 'trash': | ||
| return typeof dropTipLocation !== 'string' && | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this mean? When happens when |
||
| 'cutoutId' in dropTipLocation | ||
| ? dropTipLocation | ||
| : { | ||
| cutoutId: 'cutoutA3', | ||
| cutoutFixtureId: TRASH_BIN_ADAPTER_FIXTURE, | ||
| } | ||
| default: | ||
| return undefined | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe refactor
CutoutConfig | stringto type for reuse