-
Notifications
You must be signed in to change notification settings - Fork 186
feat(app): add tip rack to DropTipLocation as a new option #19897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## edge #19897 +/- ##
==========================================
+ Coverage 24.23% 25.55% +1.31%
==========================================
Files 3540 3516 -24
Lines 298345 297424 -921
Branches 39863 40444 +581
==========================================
+ Hits 72298 76000 +3702
+ Misses 226029 221391 -4638
- Partials 18 33 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
app/src/organisms/ODD/QuickTransferFlow/utils/isTipRackDropLocation.ts
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/QuickTransferFlow/SelectTipDropLocation.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/QuickTransferFlow/SelectTipDropLocation.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit confused by the extension of stepArgs 🤔 left a handful of comments on how to avoid the new stepArg you created.
| case 'destination': | ||
| return DEST_WELL_BLOWOUT_DESTINATION | ||
| case 'trash': | ||
| return typeof dropTipLocation !== 'string' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? When happens when dropTipLocation IS a string? And what value would dropTipLocation contain if it is a string?
| @@ -105,7 +106,7 @@ export function quickTransferWizardReducer( | |||
| case 'SET_DROP_TIP_LOCATION': { | |||
| return { | |||
| ...state, | |||
| dropTipLocation: action.location, | |||
| dropTipLocation: action.location as CutoutConfig | string, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe refactor CutoutConfig | string to type for reuse
| @@ -27,7 +27,7 @@ export interface QuickTransferWizardState { | |||
| // Note added for liquid classes in Quick Transfer | |||
| path?: PathOption | |||
| changeTip?: ChangeTipOptions | |||
| dropTipLocation?: CutoutConfig | |||
| dropTipLocation?: CutoutConfig | string | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see type comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misreading these changes, it looks like dropTipLocation is never properly passed as the tiprack URI
|
debug-protocol_name-1761662992975.py |
|
trashbin case |
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if tested on robot
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
* feat(app): add tip rack to DropTipLocation as a new option
Overview
add tip rack to TipDropLocation as a new option
close AUTH-2183
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment