Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Oct 23, 2025

Overview

add tip rack to TipDropLocation as a new option

close AUTH-2183

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@koji koji requested review from ddcc4, jerader and ncdiehl11 October 23, 2025 17:38
@koji koji marked this pull request as ready for review October 23, 2025 17:38
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 3.30579% with 117 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.55%. Comparing base (38816ee) to head (827786f).
⚠️ Report is 18 commits behind head on edge.

Files with missing lines Patch % Lines
...ickTransferFlow/utils/retrieveLiquidClassValues.ts 0.00% 29 Missing ⚠️
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% 27 Missing ⚠️
.../QuickTransferFlow/utils/convertBlowoutLocation.ts 0.00% 23 Missing ⚠️
...ms/ODD/QuickTransferFlow/SelectTipDropLocation.tsx 0.00% 22 Missing ⚠️
...p/src/organisms/ODD/QuickTransferFlow/Overview.tsx 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19897      +/-   ##
==========================================
+ Coverage   24.23%   25.55%   +1.31%     
==========================================
  Files        3540     3516      -24     
  Lines      298345   297424     -921     
  Branches    39863    40444     +581     
==========================================
+ Hits        72298    76000    +3702     
+ Misses     226029   221391    -4638     
- Partials       18       33      +15     
Flag Coverage Δ
protocol-designer 18.76% <2.50%> (+0.05%) ⬆️
step-generation 5.46% <3.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/organisms/ODD/QuickTransferFlow/types.ts 100.00% <ø> (ø)
...eration/src/commandCreators/compound/replaceTip.ts 72.27% <100.00%> (-0.13%) ⬇️
...ion/src/getNextRobotStateAndWarnings/forDropTip.ts 70.45% <100.00%> (ø)
...p/src/organisms/ODD/QuickTransferFlow/Overview.tsx 0.00% <0.00%> (ø)
...ms/ODD/QuickTransferFlow/SelectTipDropLocation.tsx 0.00% <0.00%> (ø)
.../QuickTransferFlow/utils/convertBlowoutLocation.ts 0.00% <0.00%> (ø)
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% <0.00%> (ø)
...ickTransferFlow/utils/retrieveLiquidClassValues.ts 0.00% <0.00%> (ø)

... and 314 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit confused by the extension of stepArgs 🤔 left a handful of comments on how to avoid the new stepArg you created.

@koji koji requested review from jerader and ncdiehl11 October 23, 2025 20:59
case 'destination':
return DEST_WELL_BLOWOUT_DESTINATION
case 'trash':
return typeof dropTipLocation !== 'string' &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? When happens when dropTipLocation IS a string? And what value would dropTipLocation contain if it is a string?

@@ -105,7 +106,7 @@ export function quickTransferWizardReducer(
case 'SET_DROP_TIP_LOCATION': {
return {
...state,
dropTipLocation: action.location,
dropTipLocation: action.location as CutoutConfig | string,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe refactor CutoutConfig | string to type for reuse

@@ -27,7 +27,7 @@ export interface QuickTransferWizardState {
// Note added for liquid classes in Quick Transfer
path?: PathOption
changeTip?: ChangeTipOptions
dropTipLocation?: CutoutConfig
dropTipLocation?: CutoutConfig | string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see type comment above

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm misreading these changes, it looks like dropTipLocation is never properly passed as the tiprack URI

@koji
Copy link
Contributor Author

koji commented Oct 28, 2025

debug-protocol_name-1761662992975.py

"dropTipLocation":"opentrons/opentrons_flex_96_tiprack_200ul/1"

@koji
Copy link
Contributor Author

koji commented Oct 28, 2025

trashbin case
debug-protocol_name-1761663196949.py

@koji koji requested a review from ncdiehl11 October 28, 2025 14:56
@koji koji requested a review from ncdiehl11 October 28, 2025 22:21
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if tested on robot

@koji koji dismissed jerader’s stale review October 30, 2025 16:05

Nick approved

@koji koji merged commit 58619d3 into edge Oct 30, 2025
46 of 47 checks passed
@koji koji deleted the feat_return-tip-quick-transfer branch October 30, 2025 16:05
koji added a commit that referenced this pull request Nov 3, 2025
* feat(app): add tip rack to DropTipLocation as a new option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants