add mac to the connectivity csv section of robo-diag #19971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djgomez-opentrons
requested review from
CaseyBatten,
ryanthecoder and
vegano1
sfoster1
approved these changes
Oct 30, 2025
vegano1
approved these changes
Oct 30, 2025
koji
pushed a commit
that referenced
this pull request
Nov 3, 2025
# Overview Adds an output of the robots WiFi and Ethernet MAC addresses to the Robot diagnostics QC script. Customers have requested the ability to know the MAC address of their robot before they receive it or set it up. By logging the MAC address in the output of the diagnostic scripts we can now look up the MAC address of a robot based on it's serial number in our production database. ## Test Plan and Hands on Testing Ran the test script on a Flex in the office. Checked that the MAC addresses were contained in the output CSV. ## Changelog Modifies the connectivity section of the flex diagnostics QC script in hardware testing to add wifi and ethernet mac address outputs. ## Review requests ## Risk assessment Minimal only impacts hardware testing code Co-authored-by: Ryan Howard <[email protected]>
vegano1
pushed a commit
that referenced
this pull request
Nov 3, 2025
# Overview Adds an output of the robots WiFi and Ethernet MAC addresses to the Robot diagnostics QC script. Customers have requested the ability to know the MAC address of their robot before they receive it or set it up. By logging the MAC address in the output of the diagnostic scripts we can now look up the MAC address of a robot based on it's serial number in our production database. ## Test Plan and Hands on Testing Ran the test script on a Flex in the office. Checked that the MAC addresses were contained in the output CSV. ## Changelog Modifies the connectivity section of the flex diagnostics QC script in hardware testing to add wifi and ethernet mac address outputs. ## Review requests ## Risk assessment Minimal only impacts hardware testing code Co-authored-by: Ryan Howard <[email protected]>
koji
pushed a commit
that referenced
this pull request
Nov 3, 2025
# Overview Adds an output of the robots WiFi and Ethernet MAC addresses to the Robot diagnostics QC script. Customers have requested the ability to know the MAC address of their robot before they receive it or set it up. By logging the MAC address in the output of the diagnostic scripts we can now look up the MAC address of a robot based on it's serial number in our production database. ## Test Plan and Hands on Testing Ran the test script on a Flex in the office. Checked that the MAC addresses were contained in the output CSV. ## Changelog Modifies the connectivity section of the flex diagnostics QC script in hardware testing to add wifi and ethernet mac address outputs. ## Review requests ## Risk assessment Minimal only impacts hardware testing code Co-authored-by: Ryan Howard <[email protected]>
CaseyBatten
pushed a commit
that referenced
this pull request
Nov 4, 2025
# Overview Adds an output of the robots WiFi and Ethernet MAC addresses to the Robot diagnostics QC script. Customers have requested the ability to know the MAC address of their robot before they receive it or set it up. By logging the MAC address in the output of the diagnostic scripts we can now look up the MAC address of a robot based on it's serial number in our production database. ## Test Plan and Hands on Testing Ran the test script on a Flex in the office. Checked that the MAC addresses were contained in the output CSV. ## Changelog Modifies the connectivity section of the flex diagnostics QC script in hardware testing to add wifi and ethernet mac address outputs. ## Review requests ## Risk assessment Minimal only impacts hardware testing code Co-authored-by: Ryan Howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds an output of the robots WiFi and Ethernet MAC addresses to the Robot diagnostics QC script.
Customers have requested the ability to know the MAC address of their robot before they receive it or set it up. By logging the MAC address in the output of the diagnostic scripts we can now look up the MAC address of a robot based on it's serial number in our production database.
Test Plan and Hands on Testing
Ran the test script on a Flex in the office. Checked that the MAC addresses were contained in the output CSV.
Changelog
Modifies the connectivity section of the flex diagnostics QC script in hardware testing to add wifi and ethernet mac address outputs.
Review requests
Risk assessment
Minimal only impacts hardware testing code