fix: make insert compile against rc/v12.0.0 #510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-matt-hillsdon
requested review from
BenHenning
and removed request for
a team
This was referenced May 12, 2025
BenHenning
approved these changes
May 12, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @microbit-matt-hillsdon! LGTM, though it looks like there's one conflict to resolve.
Collaborator
|
Ah, there may perhaps be not much left to do in this PR now that #512 is merged. |
Collaborator
|
Closed in favor of #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same logic as the precondition above and similar callbacks in clipboard.ts.
It builds against beta.5 and rc/v12.0.0 whereas the previous code relied on an
anythat was removed in RaspberryPiFoundation/blockly#9016 (so only builds against beta.5).I'm a bit hazy on whether the plugin is targeting beta.5 or a future release (I suspect the latter) but this change feels like progress either way.