Fix basic auth user-pass string handling #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows users to use passwords that contain ':'
Cycloctane
force-pushed
the
password_split
branch
from
34f937b to
fcbb41e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
basic auth in aiohttp-remotes cannot properly split user-pass string and proceed authentication when the password contains colon
:.According to rfc7617: the first colon in a user-pass string separates user-id and password from one another. Correct parsing requires limiting the maxsplit to 1.
Are there changes in behavior for the user?
Users can now set passwords that contain colons in basic auth.
Related issue number
Checklist