Skip to content

Fix basic auth user-pass string handling #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 5 commits into from
Aug 18, 2025
Merged

Fix basic auth user-pass string handling #530

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e00dfc6
split user and pass with the first colon (rfc7617)
Cycloctane Jul 17, 2025
0b42029
add test
Cycloctane Jul 17, 2025
fcbb41e
remove redundant test
Cycloctane Jul 17, 2025
9be2b99
Update aiohttp_remotes/basic_auth.py
Dreamsorcerer Aug 18, 2025
a8375e3
Merge branch 'master' into password_split
Dreamsorcerer Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aiohttp_remotes/basic_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async def middleware(
except (UnicodeDecodeError, UnicodeEncodeError, binascii.Error):
return await self.raise_error(request)

credentials = auth_decoded.split(":")
credentials = auth_decoded.split(":", 1)

if len(credentials) != 2:
return await self.raise_error(request)
Expand Down
22 changes: 6 additions & 16 deletions tests/test_basic_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
import pytest

import aiohttp
from aiohttp import web
from aiohttp.pytest_plugin import AiohttpClient
from aiohttp_remotes import BasicAuth, setup as _setup


async def test_basic_auth_ok(aiohttp_client: AiohttpClient) -> None:
@pytest.mark.parametrize("password", ["pass", "pass:pass:"])
async def test_basic_auth_ok(aiohttp_client: AiohttpClient, password: str) -> None:
async def handler(request: web.Request) -> web.Response:
return web.Response()

app = web.Application()
app.router.add_get("/", handler)
await _setup(app, BasicAuth("user", "pass", "realm"))
await _setup(app, BasicAuth("user", password, "realm"))
cl = await aiohttp_client(app)
resp = await cl.get("/", auth=aiohttp.BasicAuth("user", "pass"))
resp = await cl.get("/", auth=aiohttp.BasicAuth("user", password))
assert resp.status == 200


Expand Down Expand Up @@ -55,19 +58,6 @@ async def handler(request: web.Request) -> web.Response:
assert resp.headers["WWW-Authenticate"] == "Basic realm=realm"


async def test_basic_auth_malformed_req2(aiohttp_client: AiohttpClient) -> None:
async def handler(request: web.Request) -> web.Response:
return web.Response()

app = web.Application()
app.router.add_get("/", handler)
await _setup(app, BasicAuth("user", "pass", "realm"))
cl = await aiohttp_client(app)
resp = await cl.get("/", headers={"Authorization": "Basic nonbase64"})
assert resp.status == 401
assert resp.headers["WWW-Authenticate"] == "Basic realm=realm"


async def test_basic_auth_white_path(aiohttp_client: AiohttpClient) -> None:
async def handler(request: web.Request) -> web.Response:
return web.Response()
Expand Down
Loading