Skip to content

Update playwright.config for Improved Logging and Reduced Retries #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update playwright.config for Improved Logging and Reduced Retries #1073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fe055c
updated config
stefanbinoj Oct 19, 2025
fc13ae5
added github reporter
stefanbinoj Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
run: ./scripts/e2e.sh

- name: Upload Playwright HTML report
if: always()
if: ${{ !cancelled() }}
Copy link
Contributor Author

@stefanbinoj stefanbinoj Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation copied from flexile

uses: actions/upload-artifact@v4
with:
name: playwright-report
Expand Down
5 changes: 3 additions & 2 deletions playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ export default defineConfig({
/* Fail the build on CI if you accidentally left test.only in the source code. */
forbidOnly: !!process.env.CI,
/* Retry on CI only */
retries: process.env.CI ? 2 : 1,
retries: process.env.CI ? 1 : 0,
workers: process.env.CI ? "100%" : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: [["html", { open: process.env.CI ? "never" : "on-failure" }]],
reporter: process.env.CI ? [["list"], ["html"]] : "list",
Copy link
Contributor

@sm17p sm17p Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add github formatter to the CI list? It would be nice to see why the spec failed in PR reviews.

Actually I don't remember if it'd be displayed in Files changed tab but it should show up on actions run and here. We can try once maybe by failing a spec intentionally?

One caveat is there would be a slight increase in CI time, so we'll have to track it

Copy link
Contributor

@sm17p sm17p Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reporter: process.env.CI ? [["list"], ["html"]] : "list",
reporter: [["list"], ["html", { open: process.env.CI ? "never" : "on-failure" }], ["github"],

Copy link
Contributor Author

@stefanbinoj stefanbinoj Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm17p Thanks for the comment, but it seems there’s no change in the report after switching togithub
check here

Copy link
Contributor

@sm17p sm17p Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try by failing a spec?

Copy link
Contributor Author

@stefanbinoj stefanbinoj Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn’t seem like it’s anything worthwhile here

Copy link
Contributor

@sm17p sm17p Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the annotations now at both the places though

  1. https://github.com/stefanbinoj/helper/pull/14/files
1
  1. https://github.com/stefanbinoj/helper/actions/runs/19134239356/job/54682206611?pr=14#step:12:432
2


/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
use: {
/* Base URL to use in actions like `await page.goto('/')`. */
Expand Down