chore: React 18 upgrade #600
Open
+5,247
−3,473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
jwinters01
force-pushed
the
react-18-upgrade
branch
from
e57d4d9 to
2885b72
Compare
jwinters01
commented
Nov 18, 2025
package.json
Outdated
| "react-router-dom": "^5.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@cfaester/enzyme-adapter-react-18": "^0.8.0", |
Author
There was a problem hiding this comment.
This is a temporary measure. Enzyme is no longer supported past React 16, it would be better for us to move to React Testing Library in the long run. (issue for that task here: #601)
jwinters01
commented
Nov 18, 2025
| "@types/react": "^18.0.0", | ||
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", | ||
| "react-router-dom": "^5.0.0" |
Author
There was a problem hiding this comment.
we need to rely on the core UI's React router for routing to work after the upgrade
This was referenced Nov 18, 2025
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for argoproj/argo-cd#25203. Upgrades React to version 18.
Resulting Storybook