feat: add ability to use self-signed certs for email #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With argoproj/argo-cd#15394 it has been possible to use custom certs from `argocd-tls-certs-cm`. This works as intended for any notification that is based on HTTP, but _not_ for emails (since the email doesn't make use of `http.Transport`). This commit fixes that by extracting out the TLS config to a separate function which can be called by the email service. The functionality which creates an email has been extracted from the library which was previously used since there's no support for setting custom TLS configs. This also means we can get rid of the `gomodules.xyz/notify` library. Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
force-pushed
the
feat/use-cert-resolver-for-email-service
branch
from
18d0976 to
dc37e52
Compare
blakepettersson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With argoproj/argo-cd#15394 it has been possible to use custom certs from
argocd-tls-certs-cm. This works as intended for any notification that is based on HTTP, but not for emails (since the email doesn't make use ofhttp.Transport).This commit fixes that by extracting out the TLS config to a separate function which can be called by the email service. The functionality which creates an email has been extracted from the library which was previously used since there's no support for setting custom TLS configs.
This also means we can get rid of the
gomodules.xyz/notifylibrary.