Skip to content

Conversation

@pcj
Copy link
Member

@pcj pcj commented Nov 20, 2025

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (stackb_ui_js) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new Bazel module stackb_ui_js version 1.0.0 to the Bazel Central Registry. The submission follows the required structure and includes all necessary files like metadata.json, MODULE.bazel, and presubmit.yml. The changes appear to be in line with the BCR contribution guidelines. I have one suggestion regarding the presubmit.yml file to enhance the robustness of the continuous integration checks.

Comment on lines +8 to +12
name: "Build module"
platform: ${{ platform }}
bazel: ${{ bazel }}
test_targets:
- "//..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The task is named "Build module", but it only specifies test_targets. This is misleading and could result in presubmit checks passing vacuously if no test targets are found. To make the presubmit more robust, this suggestion adds build_targets to ensure all library targets are buildable and renames the task for clarity. The list format for build_targets and test_targets is changed to flow style to fit the suggestion within the original line count.

      name: "Build and test module"
      platform: ${{ platform }}
      bazel: ${{ bazel }}
      build_targets: ["//..."]
      test_targets: ["//..."]

@pcj pcj force-pushed the stackb_ui_js-v1.0.0 branch from d15cf33 to 04816fa Compare November 20, 2025 01:34
@pcj pcj force-pushed the stackb_ui_js-v1.0.0 branch from 04816fa to bb2f2d1 Compare November 20, 2025 01:48
@keith keith added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants