Clean up unused logging infrastructure #234
Conversation
The AsyncLocalStorage infrastructure (loggerStorage, getLogger, runWithLogger) was set up but never actually used. The codebase uses explicit logger passing via constructor injection throughout. This change removes the unused code, simplifies the logging module, and documents the explicit passing pattern as the canonical approach. The pattern works well for all scenarios including request context, background operations, lifecycle events, and long-lived objects. No breaking changes as the removed functions were never called.
🦋 Changeset detectedLatest commit: a4fb135 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
Looks good. This PR successfully removes unused logging infrastructure that was never called. The changes are clean and align perfectly with the codebase's explicit logger passing pattern.
What was verified:
getLogger()andrunWithLogger()had zero usage in the codebase- All code uses explicit logger passing via constructor injection
- Tests for deleted functionality appropriately removed
- CLAUDE.md documentation accurately reflects the actual pattern
- Config cleanup removes unused exports
- No breaking changes (correctly marked as patch release)
Architecture:
Removing AsyncLocalStorage improves code clarity - explicit logger passing is simpler to reason about and test than implicit context propagation.
package-lock.json changes:
These are benign peer dependency marker movements from normal lock file maintenance, not actual dependency changes.
commit: |
🐳 Docker Image PublishedFROM cloudflare/sandbox:0.0.0-pr-234-641b7d2Version: You can use this Docker image with the preview package from this PR. |
Use 'vars' instead of 'env' for environment variables in wrangler template.
1 participant
Removes unused logging infrastructure that was set up but never called. The codebase consistently uses explicit logger passing throughout.
getLogger()andrunWithLogger()functions