-
Notifications
You must be signed in to change notification settings - Fork 121
Refactoring of the GORM model for shares #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
3755df9 to
6f31fd6
Compare
23b583c to
1afe2c4
Compare
45a05c4 to
d77bc7e
Compare
|
I've tested this version and it doesn't seem to break anything in the normal shares/public links - the DB is fine without migration, however the OCM tables need to be recreated because of the rename from access methods -> protocols and the fileidprefix rename. |
|
As we've seen with Rasmus, everything works but the indexes are not created the way we want, so this requires a bit more work before going ahead. |
8c75e7b to
ef5e3cd
Compare
ef5e3cd to
2147968
Compare
2147968 to
9723609
Compare
9723609 to
2b65bfb
Compare
15a12f5 to
66af487
Compare
|
Now tested in full on a dev node - I created all types of shares and everything worked. |
8a79b2a to
bd0d3cc
Compare
ada2515 to
3f466f7
Compare
With this PR we introduce new constraints and rename some fields for better consistency:
Ocm, andAccessMethodandProtocolwereconsolidated into
OcmProtocol(FileIdPrefix, ItemSource)tuple is now(Instance, Inode)inOcmShare, and it wasremoved from
OcmReceivedShareas unusedSharesand for
OcmShareson(instance, inode, shareWith, deletedAt)u_prefix for consistency: this affected
u_shareid_user,u_link_token. Thei_share_withwas droppedas redundant.
AliasandHiddenwere added inOcmReceivedShare