-
Notifications
You must be signed in to change notification settings - Fork 121
add: LocalFS virtual namespace support #5404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MahdiBaghbani
wants to merge
16
commits into
cs3org:master
Choose a base branch
from
MahdiBaghbani:feature/multi-reva-setup-with-localhome
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
add: LocalFS virtual namespace support #5404
MahdiBaghbani
wants to merge
16
commits into
cs3org:master
from
MahdiBaghbani:feature/multi-reva-setup-with-localhome
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional VirtualHomeTemplate config to expose localhome paths in a virtual namespace (e.g., /home/<user>/) while storing files in the existing flat layout. When empty, preserves original behavior for EOS and other deployments. Fixes PathToSpaceID() encoding issues where localhome returned paths like '/file.txt' instead of '/home/<user>/file.txt', causing each file to be treated as its own space.
fix(localfs): handle gateway-stripped paths in virtual namespace
Also handle the webdav storage accessing pattern
moved the logic from unwrap() to normalize, to handle different requirements for Path and OpaqueId construction
Every single step will be logged
e5b1215 to
3465648
Compare
6ad0c55 to
6582ad2
Compare
Member
|
This looks good and makes the localfs "demo" storage more usable. @MahdiBaghbani if this is ready for review please mark it as such! |
Member
Author
|
This is unfortunately not ready yet. I'm kind of struggling on the UI right now :-), but I'll definitely do some extra test and clean the debugs for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional VirtualHomeTemplate config to expose localhome paths in a virtual namespace (e.g.,
/home/user/) while storing files in the existing flat layout. When empty, preserves original behavior for EOS and other deployments.Fixes
PathToSpaceID()encoding issues where localhome returned paths like/file.txtinstead of/home/user/file.txt, causing each file to be treated as its own space.