Skip to content

Add custom message when terminating a connection #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosuem merged 1 commit into from
Apr 4, 2025
Merged

Add custom message when terminating a connection #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkgs/http2/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 3.0.0-wip
## 3.0.0

- Require Dart SDK `3.7.0`.
- Add support for providing custom message when terminating a connection.

## 2.3.1

Expand Down
4 changes: 2 additions & 2 deletions pkgs/http2/lib/src/connection.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ abstract class Connection {
}

/// Terminates this connection forcefully.
Future<void> terminate([int? errorCode]) {
return _terminate(errorCode ?? ErrorCode.NO_ERROR);
Future<void> terminate([int? errorCode, String? message]) {
return _terminate(errorCode ?? ErrorCode.NO_ERROR, message: message);
}

void _activeStateHandler(bool isActive) =>
Expand Down
2 changes: 1 addition & 1 deletion pkgs/http2/lib/transport.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ abstract class TransportConnection {
Future finish();

/// Terminates this connection forcefully.
Future terminate([int? errorCode]);
Future terminate([int? errorCode, String? message]);
Copy link
Collaborator

@brianquinlan brianquinlan Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this class is not final, changing the signature of this method is probably breaking. I don't know how important that is.

Copy link
Member

@mosuem mosuem Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed bmw-tech/dart_apitool#207 - I do believe this is a breaking change, so this requires a version rev to 3.0.0. We should use that opportunity to do some changes like revving the minimum SDK version.

}

abstract class ClientTransportConnection extends TransportConnection {
Expand Down
2 changes: 1 addition & 1 deletion pkgs/http2/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: http2
version: 3.0.0-wip
version: 3.0.0
description: A HTTP/2 implementation in Dart.
repository: https://github.com/dart-lang/http/tree/master/pkgs/http2

Expand Down