-
Notifications
You must be signed in to change notification settings - Fork 393
Add custom message when terminating a connection #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom message when terminating a connection #1725
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
brianquinlan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to write tests for this?
|
|
||
| /// Terminates this connection forcefully. | ||
| Future terminate([int? errorCode]); | ||
| Future terminate([int? errorCode, String? message]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this class is not final, changing the signature of this method is probably breaking. I don't know how important that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed bmw-tech/dart_apitool#207 - I do believe this is a breaking change, so this requires a version rev to 3.0.0. We should use that opportunity to do some changes like revving the minimum SDK version.
6c9936e to
1f334ce
Compare
|
As this is a breaking change, we have to update the major version number according to https://semver.org/spec/v2.0.0-rc.1.html. If we do that, we might do some other major version changes to go with it. So I filed #1745 which will upgrade the used version of the Dart SDK and set the new version to |
1f334ce to
836ee7c
Compare
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Add support for providing a custom message when terminating a connection
This allows for clients to get customized messages when connections are terminated early.