Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Apr 2, 2025

Upgrade SDK to use the new formatter. To land before #1725.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Apr 2, 2025
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
http2 None 2.3.1 3.0.0-wip 2.3.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/http2/example/display_headers.dart 💔 Not covered
pkgs/http2/lib/multiprotocol_server.dart 💚 90 % ⬆️ 1 %
pkgs/http2/lib/src/artificial_server_socket.dart 💚 50 %
pkgs/http2/lib/src/async_utils/async_utils.dart 💚 100 %
pkgs/http2/lib/src/connection.dart 💚 83 % ⬆️ 1 %
pkgs/http2/lib/src/connection_preface.dart 💚 100 %
pkgs/http2/lib/src/flowcontrol/connection_queues.dart 💔 93 % ⬇️ 1 %
pkgs/http2/lib/src/flowcontrol/queue_messages.dart 💔 42 % ⬇️ 8 %
pkgs/http2/lib/src/flowcontrol/stream_queues.dart 💚 88 % ⬆️ 1 %
pkgs/http2/lib/src/flowcontrol/window_handler.dart 💚 100 %
pkgs/http2/lib/src/frames/frame_defragmenter.dart 💚 100 %
pkgs/http2/lib/src/frames/frame_reader.dart 💚 90 % ⬆️ 0 %
pkgs/http2/lib/src/frames/frame_types.dart 💚 57 % ⬆️ 26 %
pkgs/http2/lib/src/frames/frame_writer.dart 💔 86 % ⬇️ 0 %
pkgs/http2/lib/src/hpack/hpack.dart 💔 95 % ⬇️ 1 %
pkgs/http2/lib/src/hpack/huffman.dart 💚 95 %
pkgs/http2/lib/src/hpack/huffman_table.dart 💚 100 %
pkgs/http2/lib/src/ping/ping_handler.dart 💚 100 %
pkgs/http2/lib/src/settings/settings.dart 💚 94 %
pkgs/http2/lib/src/streams/stream_handler.dart 💚 91 % ⬆️ 0 %
pkgs/http2/lib/transport.dart 💚 82 %
pkgs/http2/manual_test/out_of_stream_ids_test.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart

@mosuem mosuem merged commit 32d5ffc into master Apr 2, 2025
36 checks passed
@mosuem mosuem deleted the revTo3 branch April 2, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:http2 type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants