Restore-DbaDbSnapshot - Add retry logic for deadlock errors #9900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #9233 where Restore-DbaDbSnapshot occasionally fails with deadlock errors when restoring multiple databases in parallel. The deadlock occurs when: 1. One process executes RESTORE DATABASE (holds locks on master) 2. Another process calls Get-DbaDbSnapshot (queries system tables in master) The fix implements retry logic with exponential backoff: - Detects deadlock errors (SQL error 1205) - Retries up to 3 times with 2^n second delays (2s, 4s, 8s) - Logs retry attempts at verbose level - Preserves original error handling for non-deadlock errors Co-authored-by: Chrissy LeMaire <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #9233 where Restore-DbaDbSnapshot occasionally fails with deadlock errors when restoring multiple databases in parallel.
Root Cause
The deadlock occurs when:
Solution
Implemented retry logic with exponential backoff:
Fixes #9233
Generated with Claude Code