Skip to content

Restore-DbaDbSnapshot - Add retry logic for deadlock errors #9900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
Merged

Restore-DbaDbSnapshot - Add retry logic for deadlock errors #9900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86d3a02
Restore-DbaDbSnapshot - Add retry logic for deadlock errors
github-actions[bot] Oct 31, 2025
182ae09
Merge branch 'development' into claude/issue-9233-20251031-1246
potatoqualitee Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions public/Restore-DbaDbSnapshot.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,38 @@ function Restore-DbaDbSnapshot {

# Need a proper restore now
if ($Pscmdlet.ShouldProcess($server, "Restore db $db from $snap")) {
try {
if ($Force) {
$null = Stop-DbaProcess -SqlInstance $server -Database $db.Name, $snap.Name -WarningAction SilentlyContinue
$maxRetries = 3
$retryCount = 0
$restoreSuccess = $false

while (-not $restoreSuccess -and $retryCount -lt $maxRetries) {
try {
if ($Force) {
$null = Stop-DbaProcess -SqlInstance $server -Database $db.Name, $snap.Name -WarningAction SilentlyContinue
}

$null = $server.Query("USE master; RESTORE DATABASE [$($db.Name)] FROM DATABASE_SNAPSHOT='$($snap.Name)'")
$restoreSuccess = $true
} catch {
# Check if this is a deadlock error (error 1205)
if ($_.Exception.InnerException.Number -eq 1205) {
$retryCount++
if ($retryCount -lt $maxRetries) {
$waitSeconds = [Math]::Pow(2, $retryCount)
Write-Message -Level Verbose -Message "Deadlock detected during restore of $db on $server. Retrying in $waitSeconds seconds (attempt $retryCount of $maxRetries)"
Start-Sleep -Seconds $waitSeconds
} else {
Stop-Function -Message "Failiure attempting to restore $db on $server after $maxRetries attempts due to deadlock" -ErrorRecord $_ -Continue
}
} else {
Stop-Function -Message "Failiure attempting to restore $db on $server" -ErrorRecord $_ -Continue
break
}
}
}

$null = $server.Query("USE master; RESTORE DATABASE [$($db.Name)] FROM DATABASE_SNAPSHOT='$($snap.Name)'")
} catch {
Stop-Function -Message "Failiure attempting to restore $db on $server" -ErrorRecord $_ -Continue
if (-not $restoreSuccess) {
continue
}
}

Expand Down