Allow updating transport credentials #274
swallezAnnotations
55 warnings
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/main.rs#L93
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/main.rs:93:38
|
93 | let download_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/test", stack_version));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
93 - let download_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/test", stack_version));
93 + let download_dir = PathBuf::from(format!("./checkout/{stack_version}/rest-api-spec/test"));
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/main.rs#L88
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/main.rs:88:40
|
88 | let rest_specs_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/api", stack_version));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
88 - let rest_specs_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/api", stack_version));
88 + let rest_specs_dir = PathBuf::from(format!("./checkout/{stack_version}/rest-api-spec/api"));
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/main.rs#L66
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/main.rs:66:17
|
66 | / error!(
67 | | "Problem getting values from Elasticsearch at {}. {:?}",
68 | | url, e
69 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/step/mod.rs#L198
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/step/mod.rs:198:21
|
198 | write!(expr, "[\"{}\"]", s).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
198 - write!(expr, "[\"{}\"]", s).unwrap();
198 + write!(expr, "[\"{s}\"]").unwrap();
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/step/mod.rs#L188
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/step/mod.rs:188:21
|
188 | write!(expr, "[{}.as_str().unwrap()]", t).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
188 - write!(expr, "[{}.as_str().unwrap()]", t).unwrap();
188 + write!(expr, "[{t}.as_str().unwrap()]").unwrap();
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/step/mod.rs#L181
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/step/mod.rs:181:21
|
181 | write!(expr, "[{}]", s).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
181 - write!(expr, "[{}]", s).unwrap();
181 + write!(expr, "[{s}]").unwrap();
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/step/do.rs#L649
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/step/do.rs:649:30
|
649 | syn::Ident::from(format!("{}Parts", name))
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
649 - syn::Ident::from(format!("{}Parts", name))
649 + syn::Ident::from(format!("{name}Parts"))
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/step/do.rs#L608
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/step/do.rs:608:30
|
608 | _ => println!("unsupported value {:?} for param {}", v, n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
608 - _ => println!("unsupported value {:?} for param {}", v, n),
608 + _ => println!("unsupported value {v:?} for param {n}"),
|
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/generator.rs#L545
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/generator.rs:545:32
|
545 | relative.set_file_name(format!("_{}", file_name));
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
545 - relative.set_file_name(format!("_{}", file_name));
545 + relative.set_file_name(format!("_{file_name}"));
|
|
|
`to_string` applied to a type that implements `Display` in `error!` args:
yaml_test_runner/src/generator.rs#L428
warning: `to_string` applied to a type that implements `Display` in `error!` args
--> yaml_test_runner/src/generator.rs:428:46
|
428 | result.err().unwrap().to_string()
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
variables can be used directly in the `format!` string:
yaml_test_runner/src/generator.rs#L271
warning: variables can be used directly in the `format!` string
--> yaml_test_runner/src/generator.rs:271:25
|
271 | info!("{}", s);
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
271 - info!("{}", s);
271 + info!("{s}");
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/params.rs#L474
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/params.rs:474:49
|
474 | Err(_) => Err(E::custom(format!(
| _________________________________________________^
475 | | "expected 'auto' or i32 but received: {}",
476 | | n
477 | | ))),
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/params.rs#L462
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/params.rs:462:35
|
462 | Err(E::custom(format!("i32 out of range: {}", value)))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
462 - Err(E::custom(format!("i32 out of range: {}", value)))
462 + Err(E::custom(format!("i32 out of range: {value}")))
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/params.rs#L451
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/params.rs:451:35
|
451 | Err(E::custom(format!("i32 out of range: {}", value)))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
451 - Err(E::custom(format!("i32 out of range: {}", value)))
451 + Err(E::custom(format!("i32 out of range: {value}")))
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L860
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:860:30
|
860 | let url = Url::parse(format!("https://{}.{}", uuid, domain_name).as_ref())?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
860 - let url = Url::parse(format!("https://{}.{}", uuid, domain_name).as_ref())?;
860 + let url = Url::parse(format!("https://{uuid}.{domain_name}").as_ref())?;
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L803
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:803:42
|
803 | return Err(crate::error::lib(format!(
| __________________________________________^
804 | | "cannot base 64 decode '{}'",
805 | | data
806 | | )));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L615
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:615:13
|
615 | format!("{}://{}:{}", scheme, host, port).as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
615 - format!("{}://{}:{}", scheme, host, port).as_str(),
615 + format!("{scheme}://{host}:{port}").as_str(),
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L611
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:611:31
|
611 | crate::error::lib(format!("error parsing address into url: {}", address))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
611 - crate::error::lib(format!("error parsing address into url: {}", address))
611 + crate::error::lib(format!("error parsing address into url: {address}"))
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L542
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:542:66
|
542 | let mut header_value = HeaderValue::try_from(format!("ApiKey {}", k)).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
542 - let mut header_value = HeaderValue::try_from(format!("ApiKey {}", k)).unwrap();
542 + let mut header_value = HeaderValue::try_from(format!("ApiKey {k}")).unwrap();
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L535
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:535:25
|
535 | write!(encoder, "{}", k).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
535 - write!(encoder, "{}", k).unwrap();
535 + write!(encoder, "{k}").unwrap();
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L534
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:534:25
|
534 | write!(encoder, "{}:", i).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
534 - write!(encoder, "{}:", i).unwrap();
534 + write!(encoder, "{i}:").unwrap();
|
|
|
doc list item overindented:
elasticsearch/src/http/transport.rs#L488
warning: doc list item overindented
--> elasticsearch/src/http/transport.rs:488:9
|
488 | /// identifies the deployment instance.
| ^^^^^^^^^^^^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
|
|
variables can be used directly in the `format!` string:
elasticsearch/src/http/transport.rs#L141
warning: variables can be used directly in the `format!` string
--> elasticsearch/src/http/transport.rs:141:20
|
141 | let mut meta = format!("es={},rs={},t={}", version, rustc, version);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
141 - let mut meta = format!("es={},rs={},t={}", version, rustc, version);
141 + let mut meta = format!("es={version},rs={rustc},t={version}");
|
|
|
the following explicit lifetimes could be elided: 'a:
elasticsearch/src/http/request.rs#L175
warning: the following explicit lifetimes could be elided: 'a
--> elasticsearch/src/http/request.rs:175:6
|
175 | impl<'a> Body for &'a str {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
175 - impl<'a> Body for &'a str {
175 + impl Body for &str {
|
|
|
the following explicit lifetimes could be elided: 'a:
elasticsearch/src/http/request.rs#L161
warning: the following explicit lifetimes could be elided: 'a
--> elasticsearch/src/http/request.rs:161:6
|
161 | impl<'a> Body for &'a [u8] {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
161 - impl<'a> Body for &'a [u8] {
161 + impl Body for &[u8] {
|
|
|
the following explicit lifetimes could be elided: 'a:
elasticsearch/src/http/request.rs#L53
warning: the following explicit lifetimes could be elided: 'a
--> elasticsearch/src/http/request.rs:53:6
|
53 | impl<'a, B: ?Sized> Body for &'a B
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
53 - impl<'a, B: ?Sized> Body for &'a B
53 + impl<B: ?Sized> Body for &B
|
|
|
doc list item overindented:
elasticsearch/src/lib.rs#L53
warning: doc list item overindented
--> elasticsearch/src/lib.rs:53:5
|
53 | //! caution because it is possible that breaking changes are made to these APIs in a minor version.
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
|
|
variables can be used directly in the `format!` string:
xtask/src/artifacts.rs#L69
warning: variables can be used directly in the `format!` string
--> xtask/src/artifacts.rs:69:30
|
69 | .with_context(|| format!("Cannot find commit hash {}", hash))?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
69 - .with_context(|| format!("Cannot find commit hash {}", hash))?
69 + .with_context(|| format!("Cannot find commit hash {hash}"))?
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/bin/run.rs#L35
warning: variables can be used directly in the `format!` string
--> api_generator/src/bin/run.rs:35:39
|
35 | let download_dir = PathBuf::from(&format!("./checkout/{}/rest-api-spec/api", stack_version));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
35 - let download_dir = PathBuf::from(&format!("./checkout/{}/rest-api-spec/api", stack_version));
35 + let download_dir = PathBuf::from(&format!("./checkout/{stack_version}/rest-api-spec/api"));
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/mod.rs#L727
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/mod.rs:727:18
|
727 | message: format!("Failed to parse {} because: {}", name, e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
727 - message: format!("Failed to parse {} because: {}", name, e),
727 + message: format!("Failed to parse {name} because: {e}"),
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/mod.rs#L690
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/mod.rs:690:22
|
690 | message: format!("Failed to parse {} because: {}", name, e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
690 - message: format!("Failed to parse {} because: {}", name, e),
690 + message: format!("Failed to parse {name} because: {e}"),
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/mod.rs#L573
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/mod.rs:573:19
|
573 | .map(|ns| format!("pub mod {};", ns))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
573 - .map(|ns| format!("pub mod {};", ns))
573 + .map(|ns| format!("pub mod {ns};"))
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/mod.rs#L553
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/mod.rs:553:13
|
553 | format!("{}.rs", name).as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
553 - format!("{}.rs", name).as_str(),
553 + format!("{name}.rs").as_str(),
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/mod.rs#L548
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/mod.rs:548:24
|
548 | docs_file.push(format!("{}.md", name));
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
548 - docs_file.push(format!("{}.md", name));
548 + docs_file.push(format!("{name}.md"));
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/output.rs#L64
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/output.rs:64:13
|
64 | warn!("Missing docs file {:?}", docs)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
64 - warn!("Missing docs file {:?}", docs)
64 + warn!("Missing docs file {docs:?}")
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/url/url_builder.rs#L318
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/url/url_builder.rs:318:36
|
318 | ... (ident(format!("{}_str", name)), to_string_call)
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
318 - (ident(format!("{}_str", name)), to_string_call)
318 + (ident(format!("{name}_str")), to_string_call)
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/url/url_builder.rs#L238
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/url/url_builder.rs:238:47
|
238 | let encoded_ident = ident(format!("encoded_{}", name));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
238 - let encoded_ident = ident(format!("encoded_{}", name));
238 + let encoded_ident = ident(format!("encoded_{name}"));
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/url/url_builder.rs#L235
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/url/url_builder.rs:235:40
|
235 | _ => path_none(format!("{}_str", name).as_str()).into_expr(),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
235 - _ => path_none(format!("{}_str", name).as_str()).into_expr(),
235 + _ => path_none(format!("{name}_str").as_str()).into_expr(),
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/url/url_builder.rs#L52
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/url/url_builder.rs:52:12
|
52 | Ok(format!("/{}", s))
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
52 - Ok(format!("/{}", s))
52 + Ok(format!("/{s}"))
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L732
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:732:22
|
732 | _ => doc(format!("{} API{}", api_name_for_docs, markdown_doc)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
732 - _ => doc(format!("{} API{}", api_name_for_docs, markdown_doc)),
732 + _ => doc(format!("{api_name_for_docs} API{markdown_doc}")),
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L728
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:728:61
|
728 | (None, Some(u)) if Url::parse(u).is_ok() => doc(format!(
| _____________________________________________________________^
729 | | "[{} API]({}){}",
730 | | api_name_for_docs, u, markdown_doc
731 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L724
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:724:36
|
724 | (Some(d), None) => doc(format!(
| ____________________________________^
725 | | "{} API\n\n{}{}",
726 | | api_name_for_docs, d, markdown_doc
727 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L720
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:720:64
|
720 | (Some(d), Some(u)) if Url::parse(u).is_ok() => doc(format!(
| ________________________________________________________________^
721 | | "[{} API]({})\n\n{}{}",
722 | | api_name_for_docs, u, d, markdown_doc
723 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L702
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:702:23
|
702 | path.push(format!("{}.{}.md", namespace_name, name));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
702 - path.push(format!("{}.{}.md", namespace_name, name));
702 + path.push(format!("{namespace_name}.{name}.md"));
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L624
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:624:28
|
624 | let send_doc = lit(format!(
| ____________________________^
625 | | "Creates an asynchronous call to the {} API that can be awaited",
626 | | api_name_for_docs
627 | | ));
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L621
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:621:22
|
621 | _ => lit(format!("Builder for the {} API", api_name_for_docs)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
621 - _ => lit(format!("Builder for the {} API", api_name_for_docs)),
621 + _ => lit(format!("Builder for the {api_name_for_docs} API")),
|
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L617
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:617:61
|
617 | (None, Some(u)) if Url::parse(u).is_ok() => lit(format!(
| _____________________________________________________________^
618 | | "Builder for the [{} API]({})",
619 | | api_name_for_docs, u
620 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L613
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:613:36
|
613 | (Some(d), None) => lit(format!(
| ____________________________________^
614 | | "Builder for the {} API\n\n{}",
615 | | api_name_for_docs, d
616 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
api_generator/src/generator/code_gen/request/request_builder.rs#L609
warning: variables can be used directly in the `format!` string
--> api_generator/src/generator/code_gen/request/request_builder.rs:609:64
|
609 | (Some(d), Some(u)) if Url::parse(u).is_ok() => lit(format!(
| ________________________________________________________________^
610 | | "Builder for the [{} API]({})\n\n{}",
611 | | api_name_for_docs, u, d
612 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
|
|
iterating on a map's keys:
api_generator/src/generator/code_gen/request/request_builder.rs#L157
warning: iterating on a map's keys
--> api_generator/src/generator/code_gen/request/request_builder.rs:157:30
|
157 | let query_ctor = endpoint_params.iter().map(|(param_name, _)| {
| ______________________________^
158 | | let field_name = ident(valid_name(param_name).to_lowercase());
159 | | quote! {
160 | | #field_name: self.#field_name
161 | | }
162 | | });
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `#[warn(clippy::iter_kv_map)]` on by default
help: try
|
157 ~ let query_ctor = endpoint_params.keys().map(|param_name| {
158 + let field_name = ident(valid_name(param_name).to_lowercase());
159 + quote! {
160 + #field_name: self.#field_name
161 + }
162 ~ });
|
|
|
variables can be used directly in the `format!` string:
elasticsearch/build.rs#L44
warning: variables can be used directly in the `format!` string
--> elasticsearch/build.rs:44:5
|
44 | println!("cargo:rustc-env=RUSTC_VERSION={}", rustcv);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
44 - println!("cargo:rustc-env=RUSTC_VERSION={}", rustcv);
44 + println!("cargo:rustc-env=RUSTC_VERSION={rustcv}");
|
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|