Skip to content

Allow updating transport credentials #274

Allow updating transport credentials

Allow updating transport credentials #274

GitHub Actions / clippy succeeded Apr 25, 2025 in 1s

clippy

51 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 51
Note 0
Help 0

Versions

  • rustc 1.88.0-nightly (d7ea436a0 2025-04-24)
  • cargo 1.88.0-nightly (d811228b1 2025-04-15)
  • clippy 0.1.88 (d7ea436a02 2025-04-24)

Annotations

Check warning on line 93 in yaml_test_runner/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> yaml_test_runner/src/main.rs:93:38
   |
93 |     let download_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/test", stack_version));
   |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
93 -     let download_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/test", stack_version));
93 +     let download_dir = PathBuf::from(format!("./checkout/{stack_version}/rest-api-spec/test"));
   |

Check warning on line 88 in yaml_test_runner/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> yaml_test_runner/src/main.rs:88:40
   |
88 |     let rest_specs_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/api", stack_version));
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
88 -     let rest_specs_dir = PathBuf::from(format!("./checkout/{}/rest-api-spec/api", stack_version));
88 +     let rest_specs_dir = PathBuf::from(format!("./checkout/{stack_version}/rest-api-spec/api"));
   |

Check warning on line 69 in yaml_test_runner/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> yaml_test_runner/src/main.rs:66:17
   |
66 | /                 error!(
67 | |                     "Problem getting values from Elasticsearch at {}. {:?}",
68 | |                     url, e
69 | |                 );
   | |_________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

Check warning on line 198 in yaml_test_runner/src/step/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/step/mod.rs:198:21
    |
198 |                     write!(expr, "[\"{}\"]", s).unwrap();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
198 -                     write!(expr, "[\"{}\"]", s).unwrap();
198 +                     write!(expr, "[\"{s}\"]").unwrap();
    |

Check warning on line 188 in yaml_test_runner/src/step/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/step/mod.rs:188:21
    |
188 |                     write!(expr, "[{}.as_str().unwrap()]", t).unwrap();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
188 -                     write!(expr, "[{}.as_str().unwrap()]", t).unwrap();
188 +                     write!(expr, "[{t}.as_str().unwrap()]").unwrap();
    |

Check warning on line 181 in yaml_test_runner/src/step/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/step/mod.rs:181:21
    |
181 |                     write!(expr, "[{}]", s).unwrap();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
181 -                     write!(expr, "[{}]", s).unwrap();
181 +                     write!(expr, "[{s}]").unwrap();
    |

Check warning on line 649 in yaml_test_runner/src/step/do.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/step/do.rs:649:30
    |
649 |             syn::Ident::from(format!("{}Parts", name))
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
649 -             syn::Ident::from(format!("{}Parts", name))
649 +             syn::Ident::from(format!("{name}Parts"))
    |

Check warning on line 608 in yaml_test_runner/src/step/do.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/step/do.rs:608:30
    |
608 |                         _ => println!("unsupported value {:?} for param {}", v, n),
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
608 -                         _ => println!("unsupported value {:?} for param {}", v, n),
608 +                         _ => println!("unsupported value {v:?} for param {n}"),
    |

Check warning on line 545 in yaml_test_runner/src/generator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/generator.rs:545:32
    |
545 |         relative.set_file_name(format!("_{}", file_name));
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
545 -         relative.set_file_name(format!("_{}", file_name));
545 +         relative.set_file_name(format!("_{file_name}"));
    |

Check warning on line 428 in yaml_test_runner/src/generator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `error!` args

warning: `to_string` applied to a type that implements `Display` in `error!` args
   --> yaml_test_runner/src/generator.rs:428:46
    |
428 |                         result.err().unwrap().to_string()
    |                                              ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
    = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Check warning on line 271 in yaml_test_runner/src/generator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> yaml_test_runner/src/generator.rs:271:25
    |
271 |                         info!("{}", s);
    |                         ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
    |
271 -                         info!("{}", s);
271 +                         info!("{s}");
    |

Check warning on line 477 in elasticsearch/src/params.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/params.rs:474:49
    |
474 |                           Err(_) => Err(E::custom(format!(
    |  _________________________________________________^
475 | |                             "expected 'auto' or i32 but received: {}",
476 | |                             n
477 | |                         ))),
    | |_________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

Check warning on line 462 in elasticsearch/src/params.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/params.rs:462:35
    |
462 |                     Err(E::custom(format!("i32 out of range: {}", value)))
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
462 -                     Err(E::custom(format!("i32 out of range: {}", value)))
462 +                     Err(E::custom(format!("i32 out of range: {value}")))
    |

Check warning on line 451 in elasticsearch/src/params.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/params.rs:451:35
    |
451 |                     Err(E::custom(format!("i32 out of range: {}", value)))
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
451 -                     Err(E::custom(format!("i32 out of range: {}", value)))
451 +                     Err(E::custom(format!("i32 out of range: {value}")))
    |

Check warning on line 860 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:860:30
    |
860 |         let url = Url::parse(format!("https://{}.{}", uuid, domain_name).as_ref())?;
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
860 -         let url = Url::parse(format!("https://{}.{}", uuid, domain_name).as_ref())?;
860 +         let url = Url::parse(format!("https://{uuid}.{domain_name}").as_ref())?;
    |

Check warning on line 806 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:803:42
    |
803 |               return Err(crate::error::lib(format!(
    |  __________________________________________^
804 | |                 "cannot base 64 decode '{}'",
805 | |                 data
806 | |             )));
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

Check warning on line 615 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:615:13
    |
615 |             format!("{}://{}:{}", scheme, host, port).as_str(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
615 -             format!("{}://{}:{}", scheme, host, port).as_str(),
615 +             format!("{scheme}://{host}:{port}").as_str(),
    |

Check warning on line 611 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:611:31
    |
611 |             crate::error::lib(format!("error parsing address into url: {}", address))
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
611 -             crate::error::lib(format!("error parsing address into url: {}", address))
611 +             crate::error::lib(format!("error parsing address into url: {address}"))
    |

Check warning on line 542 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:542:66
    |
542 |                     let mut header_value = HeaderValue::try_from(format!("ApiKey {}", k)).unwrap();
    |                                                                  ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
542 -                     let mut header_value = HeaderValue::try_from(format!("ApiKey {}", k)).unwrap();
542 +                     let mut header_value = HeaderValue::try_from(format!("ApiKey {k}")).unwrap();
    |

Check warning on line 535 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:535:25
    |
535 |                         write!(encoder, "{}", k).unwrap();
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
535 -                         write!(encoder, "{}", k).unwrap();
535 +                         write!(encoder, "{k}").unwrap();
    |

Check warning on line 534 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:534:25
    |
534 |                         write!(encoder, "{}:", i).unwrap();
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
534 -                         write!(encoder, "{}:", i).unwrap();
534 +                         write!(encoder, "{i}:").unwrap();
    |

Check warning on line 488 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item overindented

warning: doc list item overindented
   --> elasticsearch/src/http/transport.rs:488:9
    |
488 |     ///               identifies the deployment instance.
    |         ^^^^^^^^^^^^^^ help: try using `  ` (2 spaces)
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items

Check warning on line 141 in elasticsearch/src/http/transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> elasticsearch/src/http/transport.rs:141:20
    |
141 |     let mut meta = format!("es={},rs={},t={}", version, rustc, version);
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
    |
141 -     let mut meta = format!("es={},rs={},t={}", version, rustc, version);
141 +     let mut meta = format!("es={version},rs={rustc},t={version}");
    |

Check warning on line 175 in elasticsearch/src/http/request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> elasticsearch/src/http/request.rs:175:6
    |
175 | impl<'a> Body for &'a str {
    |      ^^            ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
175 - impl<'a> Body for &'a str {
175 + impl Body for &str {
    |

Check warning on line 161 in elasticsearch/src/http/request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> elasticsearch/src/http/request.rs:161:6
    |
161 | impl<'a> Body for &'a [u8] {
    |      ^^            ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
161 - impl<'a> Body for &'a [u8] {
161 + impl Body for &[u8] {
    |