Skip to content

Conversation

@giorgi-imerlishvili-elastic
Copy link
Contributor

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic commented Oct 7, 2025

Proposed commit message

Fix: [Azure App Service]: Expects JSON object but is unparsed JSON string #11169
Fix: [Azure App Service] Missing azure.subscription_id #11172

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

…tions

# Conflicts:
#	packages/statsd_input/changelog.yml
#	packages/statsd_input/manifest.yml
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic added bugfix Pull request that fixes a bug issue Integration:azure_app_service Azure App Service labels Oct 7, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 7, 2025

🚀 Benchmarks report

Package azure_app_service 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
app_service_logs 4608.29 1669.45 -2938.84 (-63.77%) 💔

To see the full report comment with /test benchmark fullreport

Comment on lines +31 to +33
- set:
field: azure.app_service.properties_raw
value: "{{{azure.app_service.properties}}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this renaming needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in appservice-platformlogs-inner-pipeline.yml in azure.app_service.log field we were setting value of azure.app_service.properties which were expected as string (actually it's json string).
But in other pipelines we need to decode that JSON in order to get values of decoded fields.

So this properties_raw is just temporary field in order to set azure.app_service.log field in appservice-platformlogs-inner-pipeline.yml

Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test this PR when it's ready for review. It also needs a changelog entry.

@muthu-mps
Copy link
Contributor

Will test this PR when it's ready for review. It also needs a changelog entry.

@giorgi-imerlishvili-elastic - Can you address this comment?

@giorgi-imerlishvili-elastic
Copy link
Contributor Author

Will test this PR when it's ready for review. It also needs a changelog entry.

@giorgi-imerlishvili-elastic - Can you address this comment?

I was thinking to make it ready for review once this is merged #15487
because that PR adds another changelog to this package

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic marked this pull request as ready for review October 22, 2025 07:15
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic requested a review from a team as a code owner October 22, 2025 07:15
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Oct 22, 2025
Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline improvements LGTM.

ignore_failure: true
- set:
field: azure.app_service.properties_raw
value: "{{{azure.app_service.properties}}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giorgi-imerlishvili-elastic - Can we add comment about this change. Otherwise this seems to be like adding a field and removing the same field without any processing. Also in the platformlogs-inner-pipeline the properties field is removed. Is it valid?

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @giorgi-imerlishvili-elastic

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic merged commit ab7dba9 into elastic:main Oct 30, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package azure_app_service - 0.10.0 containing this change is available at https://epr.elastic.co/package/azure_app_service/0.10.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:azure_app_service Azure App Service Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Azure App Service] Missing azure.subscription_id [Azure App Service]: Expects JSON object but is unparsed JSON string

5 participants