[ES|QL] Lookup join - Open in discover tab support #241317

sddonne · 2025-10-30T15:38:53Z

Part of 235730

Summary

Now "Open in Discover" button opens in a new Discover tab instead of a browser tab.

If there are unsaved changes, a confirmation modal is shown before leaving.
If there are not unsaved changes, it opens the new tab right away.
If tabs feature is disabled, it opens Discover in a new browser tab.
If Discover callback for handling tab navigation is not provided, it opens Discover in a new browser tab.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

… the containing app

…ally for the containing app" This reverts commit ba4125d.

elasticmachine · 2025-10-31T13:33:16Z

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula

Looks great, some small comments from my side

stratoula · 2025-11-05T06:26:28Z

src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx

  disableAutoFocus,
  controlsContext,
  esqlVariables,
+  onOpenQueryInNewTab,


Why in one component is onOpenQuery and on the other is onOpenIndex ?

From the index editor point of view, it wants to open a specific index in a new tab.
From the esql editor point of view, it provides a general purpose callback to open any kind of query in a new tab.

I see, makes sense

stratoula · 2025-11-05T06:30:19Z

src/platform/packages/private/kbn-index-editor/src/components/query_bar.tsx

  }, [share?.url.locators]);

+  const isOpeningInNewTabEnabled = useMemo(
+    () => featureFlags?.getBooleanValue('discover.tabsEnabled', true) ?? true,


Are we tracking this somewhere? I understand why you didnt add the constant from here src/platform/plugins/shared/discover/public/constants.ts but we might miss it when the discovery team removes the flag.

@davismcphee is there any issue already for this to add a comment?

Would it be possible to add the check directly to the Discover codebase instead, that way we can use the const? Would be great to keep references to the flag within Discover as much as possible. Thinking we could check the flag and pass undefined for onOpenQueryInNewTab if it's disabled.

In either case though, we do have an issue for it here to reference: #235232.

yes this is much better, it would be great if we can do it ++

Good idea! here it is 198d6aa

src/platform/plugins/shared/unified_search/public/query_string_input/query_bar_top_row.tsx

src/platform/packages/private/kbn-index-editor/src/components/query_bar.tsx

stratoula

I didnt test again, thanx Sebastian, looks very nice

ThomThomson

Small Unified search changes LGTM! Code review only

davismcphee

Data Discovery changes LGTM and it works well, thanks!

davismcphee · 2025-11-05T21:33:11Z

src/platform/packages/private/kbn-index-editor/src/components/query_bar.tsx

  }, [share?.url.locators]);

+  const isOpeningInNewTabEnabled = useMemo(
+    () => featureFlags?.getBooleanValue('discover.tabsEnabled', true) ?? true,


Would it be possible to add the check directly to the Discover codebase instead, that way we can use the const? Would be great to keep references to the flag within Discover as much as possible. Thinking we could check the flag and pass undefined for onOpenQueryInNewTab if it's disabled.

In either case though, we do have an issue for it here to reference: #235232.

elasticmachine · 2025-11-06T10:45:17Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: b0dce8a

Failed CI Steps

FTR Configs #95

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/index-editor`	21	24	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	1.2MB	1.2MB	+135.0B
`esql`	579.4KB	579.8KB	+392.0B
`unifiedSearch`	407.9KB	408.0KB	+93.0B
total			+620.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`unifiedSearch`	22.7KB	22.7KB	+42.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/index-editor`	24	27	+3

ESLint disabled line counts

id	before	after	diff
`@kbn/index-editor`	2	3	+1

Total ESLint disabled count

id	before	after	diff
`@kbn/index-editor`	2	3	+1

History

💔 Build #358850 failed 198d6aa
💚 Build #358442 succeeded b30d141
💛 Build #358161 was flaky 3a8ba92
💚 Build #357206 succeeded c35cbe6
💔 Build #357106 failed ba4125d

Part of [235730](elastic#235730) ## Summary Now "Open in Discover" button opens in a new Discover tab instead of a browser tab. * If there are unsaved changes, a confirmation modal is shown before leaving. * If there are not unsaved changes, it opens the new tab right away. * If tabs feature is disabled, it opens Discover in a new browser tab. * If Discover callback for handling tab navigation is not provided, it opens Discover in a new browser tab. ![tab-2](https://github.com/user-attachments/assets/45497f9c-5d6c-448e-ae37-368cb31dc84e) ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

sddonne added 7 commits October 30, 2025 15:03

open in discover using a new tab

a7356ab

display confirmation modal before leaving to discover

75c93b0

comments

ab555d5

if tabs are disabled, open discover in a new browser tab

30a4545

Enable the lookup join flyout using a flag, not checking manually for…

ba4125d

… the containing app

Revert "Enable the lookup join flyout using a flag, not checking manu…

9785d3a

…ally for the containing app" This reverts commit ba4125d.

rename interface

bbe4cc9

sddonne marked this pull request as ready for review October 31, 2025 13:32

sddonne requested review from a team as code owners October 31, 2025 13:32

Merge branch 'main' into lookup-join-tabs

c35cbe6

sddonne added v9.3.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Oct 31, 2025

sddonne added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Oct 31, 2025

Merge branch 'main' into lookup-join-tabs

3a8ba92

stratoula reviewed Nov 5, 2025

View reviewed changes

sddonne added 3 commits November 5, 2025 10:08

Improve documentation for onOpenQueryInNewTab

42d564b

es lint improvement

368fb55

clean unused async

b30d141

stratoula approved these changes Nov 5, 2025

View reviewed changes

ThomThomson approved these changes Nov 5, 2025

View reviewed changes

davismcphee approved these changes Nov 5, 2025

View reviewed changes

sddonne added 2 commits November 6, 2025 09:35

check tabsEnabled feature flag in discover

198d6aa

clean unused var

b0dce8a

sddonne merged commit 20e089c into elastic:main Nov 6, 2025
12 checks passed

[ES|QL] Lookup join - Open in discover tab support #241317

[ES|QL] Lookup join - Open in discover tab support #241317

Uh oh!

Conversation

sddonne commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 31, 2025

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 6, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sddonne commented Oct 30, 2025 •

edited

Loading