[ES|QL] Lookup join - Open in discover tab support

src/platform/packages/private/kbn-esql-editor/src/custom_commands/use_lookup_index_editor.tsx

@@ -140,7 +140,8 @@ export const useLookupIndexCommand = (
   getLookupIndices: (() => Promise<{ indices: IndexAutocompleteItem[] }>) | undefined,
   query: AggregateQuery,
   onIndexCreated: (resultQuery: string) => Promise<void>,
-  onNewFieldsAddedToIndex?: (indexName: string) => void
+  onNewFieldsAddedToIndex?: (indexName: string) => void,
+  onOpenIndexInDiscover?: EditLookupIndexContentContext['onOpenIndexInDiscover']
 ) => {
   const { euiTheme } = useEuiTheme();
   const {
@@ -296,9 +297,10 @@ export const useLookupIndexCommand = (
             indexHasNewFields
           );
         },
+        onOpenIndexInDiscover,
       } as EditLookupIndexContentContext);
     },
-    [onFlyoutClose, uiActions]
+    [onFlyoutClose, onOpenIndexInDiscover, uiActions]
   );
 
   const openFlyoutRef = useRef(openFlyout);

src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx

@@ -126,6 +126,7 @@ const ESQLEditorInternal = function ESQLEditor({
   disableAutoFocus,
   controlsContext,
   esqlVariables,
+  onOpenQueryInNewTab,
   expandToFitQueryOnMount,
   dataErrorsControl,
   formLabel,
@@ -769,7 +770,8 @@ const ESQLEditorInternal = function ESQLEditor({
     getJoinIndices,
     query,
     onLookupIndexCreate,
-    onNewFieldsAddedToLookupIndex
+    onNewFieldsAddedToLookupIndex,
+    onOpenQueryInNewTab
   );
 
   useDebounceWithOptions(

src/platform/packages/private/kbn-esql-editor/src/types.ts

@@ -91,6 +91,8 @@ export interface ESQLEditorProps {
   disableAutoFocus?: boolean;
   /** Enables the creation of controls from the editor **/
   controlsContext?: ControlsContext;
+  /** Opens the given query in a new Discover tab **/
+  onOpenQueryInNewTab?: (tabName: string, esqlQuery: string) => Promise<void>;
   /** The available ESQL variables from the page context this editor was opened in */
   esqlVariables?: ESQLControlVariable[];
   /** Resize the editor to fit the initially passed query on mount */

src/platform/packages/private/kbn-index-editor/src/components/flyout_content.tsx

@@ -138,7 +138,7 @@ export const FlyoutContent: FC<FlyoutContentProps> = ({ deps, props }) => {
               {dataView ? (
                 <EuiFlexGroup direction="column" gutterSize="s" css={{ height: '100%' }}>
                   <EuiFlexItem grow={false}>
-                    <QueryBar />
+                    <QueryBar onOpenIndexInDiscover={props.onOpenIndexInDiscover} />
                   </EuiFlexItem>
 
                   <EuiFlexItem grow={true} css={{ minHeight: 0 }}>

src/platform/packages/private/kbn-index-editor/src/components/modals/unsaved_changes_modal.tsx

@@ -28,19 +28,20 @@ export const UnsavedChangesModal: React.FC<UnsavedChangesModal> = ({ onClose })
 
   const exitAttemptWithUnsavedFields = useObservable(
     indexUpdateService.exitAttemptWithUnsavedChanges$,
-    false
+    { isActive: false }
   );
 
   const closeWithoutSaving = () => {
     indexUpdateService.discardUnsavedChanges();
     onClose();
+    exitAttemptWithUnsavedFields.onExitCallback?.();
   };
 
   const continueEditing = () => {
     indexUpdateService.setExitAttemptWithUnsavedChanges(false);
   };
 
-  if (!exitAttemptWithUnsavedFields) {
+  if (!exitAttemptWithUnsavedFields.isActive) {
     return null;
   }
 

src/platform/packages/private/kbn-index-editor/src/components/query_bar.tsx

@@ -7,7 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import React, { useMemo, useState } from 'react';
+/* eslint-disable @elastic/eui/href-or-on-click */
+
+import React, { useCallback, useMemo, useState } from 'react';
 import {
   EuiButton,
   EuiFlexGroup,
@@ -20,11 +22,15 @@ import { useKibana } from '@kbn/kibana-react-plugin/public';
 import useObservable from 'react-use/lib/useObservable';
 import { FormattedMessage } from '@kbn/i18n-react';
 import { FilePicker } from './file_picker';
-import type { KibanaContextExtra } from '../types';
+import type { EditLookupIndexContentContext, KibanaContextExtra } from '../types';
 
-export const QueryBar = () => {
+export const QueryBar = ({
+  onOpenIndexInDiscover,
+}: {
+  onOpenIndexInDiscover?: EditLookupIndexContentContext['onOpenIndexInDiscover'];
+}) => {
   const {
-    services: { share, data, indexUpdateService, indexEditorTelemetryService },
+    services: { share, data, indexUpdateService, indexEditorTelemetryService, featureFlags },
   } = useKibana<KibanaContextExtra>();
 
   const dataView = useObservable(indexUpdateService.dataView$);
@@ -34,13 +40,20 @@ export const QueryBar = () => {
     indexUpdateService.indexCreated$,
     indexUpdateService.isIndexCreated()
   );
+  const indexName = useObservable(indexUpdateService.indexName$, null);
 
   const [queryError, setQueryError] = useState<string>('');
 
   const discoverLocator = useMemo(() => {
     return share?.url.locators.get('DISCOVER_APP_LOCATOR');
   }, [share?.url.locators]);
 
+  const isOpeningInNewTabEnabled = useMemo(
+    () => featureFlags?.getBooleanValue('discover.tabsEnabled', true) ?? true,
+    [featureFlags]
+  );
+
+  // Only used as fallback if onOpenIndexInDiscover is not provided or tabs are disabled
   const discoverLink =
     isIndexCreated && esqlDiscoverQuery
       ? discoverLocator?.getRedirectUrl({
@@ -51,6 +64,29 @@ export const QueryBar = () => {
         })
       : null;
 
+  const openInDiscover = useCallback(
+    async (e: React.MouseEvent) => {
+      indexEditorTelemetryService.trackQueryThisIndexClicked(searchQuery);
+
+      // If onOpenIndexInDiscover is provided, we let that handler to manage the navigation to Discover
+      // If not, the button href will be executed
+      if (isOpeningInNewTabEnabled && onOpenIndexInDiscover && indexName && esqlDiscoverQuery) {
+        e.preventDefault();
+        const onExitCallback = () => onOpenIndexInDiscover(indexName, esqlDiscoverQuery);
+        indexUpdateService.exit(onExitCallback);
+      }
+    },
+    [
+      indexEditorTelemetryService,
+      searchQuery,
+      isOpeningInNewTabEnabled,
+      onOpenIndexInDiscover,
+      indexName,
+      esqlDiscoverQuery,
+      indexUpdateService,
+    ]
+  );
+
   if (!dataView) {
     return null;
   }
@@ -82,13 +118,13 @@ export const QueryBar = () => {
       </EuiFlexItem>
       <EuiFlexItem grow={false}>
         <EuiButton
-          size={'s'}
-          color={'text'}
-          isDisabled={!discoverLink}
-          href={discoverLink ?? undefined}
-          onClick={() => indexEditorTelemetryService.trackQueryThisIndexClicked(searchQuery)}
+          size="s"
+          color="text"
+          isDisabled={!isIndexCreated || !esqlDiscoverQuery}
+          onClick={openInDiscover}
+          href={discoverLink || undefined}
           target="_blank"
-          iconType={'discoverApp'}
+          iconType="discoverApp"
         >
           <EuiText size="xs">
             <FormattedMessage

src/platform/packages/private/kbn-index-editor/src/index_update_service.ts

@@ -189,7 +189,11 @@ export class IndexUpdateService {
   private readonly _error$ = new BehaviorSubject<IndexEditorError | null>(null);
   public readonly error$: Observable<IndexEditorError | null> = this._error$.asObservable();
 
-  private readonly _exitAttemptWithUnsavedChanges$ = new BehaviorSubject<boolean>(false);
+  private readonly _exitAttemptWithUnsavedChanges$ = new BehaviorSubject<{
+    isActive: boolean;
+    onExitCallback?: () => void;
+  }>({ isActive: false });
+
   public readonly exitAttemptWithUnsavedChanges$ =
     this._exitAttemptWithUnsavedChanges$.asObservable();
 
@@ -965,8 +969,8 @@ export class IndexUpdateService {
     this.telemetry.trackEditInteraction({ actionType: 'delete_column' });
   }
 
-  public setExitAttemptWithUnsavedChanges(value: boolean) {
-    this._exitAttemptWithUnsavedChanges$.next(value);
+  public setExitAttemptWithUnsavedChanges(isActive: boolean, onExitCallback?: () => void) {
+    this._exitAttemptWithUnsavedChanges$.next({ isActive, onExitCallback });
   }
 
   public discardUnsavedChanges() {
@@ -1059,16 +1063,17 @@ export class IndexUpdateService {
     return lookupIndexesResult.indices.some((index) => index.name === indexName);
   }
 
-  public exit() {
+  public exit(onExitCallback?: () => void) {
     const hasUnsavedChanges = this._hasUnsavedChanges$.getValue();
     const unsavedColumns = this._pendingColumnsToBeSaved$
       .getValue()
       .filter((col) => !isPlaceholderColumn(col.name));
 
     if (hasUnsavedChanges || unsavedColumns.length > 0) {
-      this.setExitAttemptWithUnsavedChanges(true);
+      this.setExitAttemptWithUnsavedChanges(true, onExitCallback);
     } else {
       this.destroy();
+      onExitCallback?.();
     }
   }
 }

src/platform/packages/private/kbn-index-editor/src/types.ts

@@ -32,6 +32,7 @@ export interface EditLookupIndexContentContext {
     /** Indicates if new fields have been added to the index */
     indexHasNewFields: boolean;
   }) => void;
+  onOpenIndexInDiscover?: (indexName: string, esqlQuery: string) => Promise<void>;
 }
 
 export interface EditLookupIndexFlyoutDeps {

src/platform/plugins/shared/discover/public/application/main/components/top_nav/discover_topnav.tsx

@@ -99,6 +99,18 @@ export const DiscoverTopNav = ({
     onUpdateESQLQuery: stateContainer.actions.updateESQLQuery,
   });
 
+  const onOpenQueryInNewTab = useCallback(
+    async (tabName: string, esqlQuery: string) => {
+      dispatch(
+        internalStateActions.openInNewTab({
+          tabLabel: tabName,
+          appState: { query: { esql: esqlQuery } },
+        })
+      );
+    },
+    [dispatch]
+  );
+
   useEffect(() => {
     return () => {
       // Make sure to close the editors when unmounting
@@ -316,6 +328,7 @@ export const DiscoverTopNav = ({
               }
             : undefined
         }
+        onOpenQueryInNewTab={onOpenQueryInNewTab}
       />
       {isESQLToDataViewTransitionModalVisible && (
         <ESQLToDataViewTransitionModal onClose={onESQLToDataViewTransitionModalClose} />

src/platform/plugins/shared/unified_search/public/query_string_input/query_bar_top_row.tsx

@@ -232,6 +232,10 @@ export interface QueryBarTopRowProps<QT extends Query | AggregateQuery = Query>
      */
     controlsWrapper: React.ReactNode;
   };
+  /**
+   * Optional - Callback function invoked to open the current query in a new Discover tab
+   */
+  onOpenQueryInNewTab?: ESQLEditorProps['onOpenQueryInNewTab'];
   useBackgroundSearchButton?: boolean;
   showProjectPicker?: boolean;
 }
@@ -919,6 +923,7 @@ export const QueryBarTopRow = React.memo(
                 : undefined
             }
             esqlVariables={props.esqlVariablesConfig?.esqlVariables ?? []}
+            onOpenQueryInNewTab={props.onOpenQueryInNewTab}
           />
         )
       );

src/platform/plugins/shared/unified_search/public/search_bar/create_search_bar.tsx

@@ -279,6 +279,7 @@ export function createSearchBar({
             esqlEditorInitialState={props.esqlEditorInitialState}
             onEsqlEditorInitialStateChange={props.onEsqlEditorInitialStateChange}
             esqlVariablesConfig={props.esqlVariablesConfig}
+            onOpenQueryInNewTab={props.onOpenQueryInNewTab}
             useBackgroundSearchButton={props.useBackgroundSearchButton}
           />
         </core.i18n.Context>

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx

@@ -162,6 +162,9 @@ export interface SearchBarOwnProps<QT extends AggregateQuery | Query = Query> {
    */
   esqlVariablesConfig?: QueryBarTopRowProps['esqlVariablesConfig'];
 
+  /** Optional configurations for the lookup join index editor */
+  onOpenQueryInNewTab?: QueryBarTopRowProps['onOpenQueryInNewTab'];
+
   esqlEditorInitialState?: QueryBarTopRowProps['esqlEditorInitialState'];
   onEsqlEditorInitialStateChange?: QueryBarTopRowProps['onEsqlEditorInitialStateChange'];
 
@@ -782,6 +785,7 @@ export class SearchBarUI<QT extends (Query | AggregateQuery) | Query = Query> ex
           esqlEditorInitialState={this.props.esqlEditorInitialState}
           onEsqlEditorInitialStateChange={this.props.onEsqlEditorInitialStateChange}
           esqlVariablesConfig={this.props.esqlVariablesConfig}
+          onOpenQueryInNewTab={this.props.onOpenQueryInNewTab}
           useBackgroundSearchButton={this.props.useBackgroundSearchButton}
           showProjectPicker={this.props.showProjectPicker}
         />