[Discover] Fix test failures due to navigation tour #241395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
added
the
Team:DataDiscovery
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9689[✅] x-pack/solutions/observability/test/serverless/functional/configs/config.ml_and_discover.ts: 50/50 tests passed. |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
reviewed
Oct 31, 2025
| public async switchTo(name: string) { | ||
| // TODO: remove in https://github.com/elastic/kibana/issues/239313 | ||
| if (await this.testSubjects.exists('nav-tour-skip-button')) { | ||
| await this.testSubjects.click('nav-tour-skip-button'); |
Contributor
There was a problem hiding this comment.
We could also add await this.testSubjects.waitForDeleted('nav-tour-skip-button');
Dosant
approved these changes
Oct 31, 2025
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
Thanks. Sorry you have to do this hack.
Maybe there is localstorage clean up happening somewhere in-between your tests 🤷
davismcphee
added
release_note:skip
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @davismcphee |
ana-davydova
pushed a commit
to ana-davydova/kibana
that referenced
this pull request
Nov 3, 2025
## Summary This PR fixes the flaky Discover tests caused by the new navigation tour blocking the data view picker: <img src="https://github.com/user-attachments/assets/48173cbb-c2dc-46be-b959-784bf7dd5681" /> Looks like the tour still shows sometimes even though `browser.setLocalStorageItem('solutionNavigationTour:completed', 'true')` should run when `loginWithRole` is called, and I wasn't able to reproduce it locally. I'm open to suggestions for alternatives, but for now I'm just manually skipping the tour if it's visible before switching data views. Seems like the tour (and this workaround) will be removed in elastic#239313 anyway. Resolves elastic#241044. Resolves elastic#241042. Resolves elastic#240915. Resolves elastic#240912. Resolves elastic#240855. Resolves elastic#240798. Resolves elastic#240504. Resolves elastic#240369. Resolves elastic#240288. Resolves elastic#240242. Resolves elastic#240167. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
albertoblaz
pushed a commit
to albertoblaz/kibana
that referenced
this pull request
Nov 4, 2025
## Summary This PR fixes the flaky Discover tests caused by the new navigation tour blocking the data view picker: <img src="https://github.com/user-attachments/assets/48173cbb-c2dc-46be-b959-784bf7dd5681" /> Looks like the tour still shows sometimes even though `browser.setLocalStorageItem('solutionNavigationTour:completed', 'true')` should run when `loginWithRole` is called, and I wasn't able to reproduce it locally. I'm open to suggestions for alternatives, but for now I'm just manually skipping the tour if it's visible before switching data views. Seems like the tour (and this workaround) will be removed in elastic#239313 anyway. Resolves elastic#241044. Resolves elastic#241042. Resolves elastic#240915. Resolves elastic#240912. Resolves elastic#240855. Resolves elastic#240798. Resolves elastic#240504. Resolves elastic#240369. Resolves elastic#240288. Resolves elastic#240242. Resolves elastic#240167. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the flaky Discover tests caused by the new navigation tour blocking the data view picker:
Looks like the tour still shows sometimes even though
browser.setLocalStorageItem('solutionNavigationTour:completed', 'true')should run whenloginWithRoleis called, and I wasn't able to reproduce it locally. I'm open to suggestions for alternatives, but for now I'm just manually skipping the tour if it's visible before switching data views. Seems like the tour (and this workaround) will be removed in #239313 anyway.Resolves #241044.
Resolves #241042.
Resolves #240915.
Resolves #240912.
Resolves #240855.
Resolves #240798.
Resolves #240504.
Resolves #240369.
Resolves #240288.
Resolves #240242.
Resolves #240167.
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.