Skip to content

[Discover] Fix test failures due to navigation tour #241395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

[Discover] Fix test failures due to navigation tour #241395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dca61e
[Discover] Fix test failures due to navigation tour
davismcphee Oct 31, 2025
84867c2
Add waitForDeleted
davismcphee Oct 31, 2025
b0ed0f7
Merge branch 'main' into fix-discover-tour-test-failures
davismcphee Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core/packages/chrome/navigation-tour/src/tour.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,12 @@ function ActiveTour({ state, tourManager }: { state: TourState; tourManager: Tou
</EuiButton>
) : (
[
<EuiButtonEmpty size="s" color="text" onClick={handleSkip}>
<EuiButtonEmpty
size="s"
color="text"
onClick={handleSkip}
data-test-subj="nav-tour-skip-button"
>
<FormattedMessage
id="core.chrome.navigationTour.skipTourButton"
defaultMessage="Skip tour"
Expand Down
4 changes: 4 additions & 0 deletions src/platform/test/functional/services/data_views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ export class DataViewsService extends FtrService {
* Switch Data View from top search bar
*/
public async switchTo(name: string) {
// TODO: remove in https://github.com/elastic/kibana/issues/239313
if (await this.testSubjects.exists('nav-tour-skip-button')) {
await this.testSubjects.click('nav-tour-skip-button');
Copy link
Contributor

@jughosta jughosta Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add await this.testSubjects.waitForDeleted('nav-tour-skip-button');

Copy link
Contributor Author

@davismcphee davismcphee Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, updated here: 84867c2.

}
const selectedDataView = await this.getSelectedName();
if (name === selectedDataView) {
return;
Expand Down