fix(*): updated peer dependencies #1187
Merged
+762
−801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dackers86
force-pushed
the
@invertase/fix-peer-dependencies
branch
from
9f65890 to
7294143
Compare
- Update Firebase catalog version from ^11.8.0 to ^11.10.0 - Change peer dependencies catalog Firebase range from ^12 to ^11 || ^12 - Reorganize workspace YAML structure with proper sections and comments - Restore Apache License copyright header - Ensure AngularFire compatibility while allowing Firebase v12 flexibility
dackers86
force-pushed
the
@invertase/fix-peer-dependencies
branch
2 times, most recently
from
da08148 to
a275905
Compare
dackers86
force-pushed
the
@invertase/fix-peer-dependencies
branch
from
cd7abc0 to
a51d40c
Compare
- Move @firebase-ui/translations from regular dependency to peer dependency in core package - Ensures proper dependency management where core declares translations as peer dependency - Consuming applications must provide translations package - Maintains existing Angular package structure which already has translations as peer dependency - React package correctly gets translations through core (no direct dependency needed) - Apply code formatting fixes
- Remove @firebase-ui/translations from Angular package peer dependencies - Angular package gets translations through core package's peer dependency - Maintains consistent dependency structure across all packages - Core declares translations as peer dependency, other packages inherit it
Ehesp
reviewed
Sep 17, 2025
Ehesp
reviewed
Sep 18, 2025
packages/angular/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@firebase-ui/core": "workspace:*", | ||
| "@firebase-ui/translations": "workspace:*", |
Member
There was a problem hiding this comment.
This isn't needed... core should pull it in
Ehesp
reviewed
Sep 18, 2025
packages/core/package.json
Outdated
| "nanostores": "catalog:", | ||
| "zod": "catalog:" | ||
| "zod": "catalog:", | ||
| "@firebase-ui/translations": "workspace:*" |
Member
There was a problem hiding this comment.
namespaced imports should come at the top of the list
dackers86
force-pushed
the
@invertase/fix-peer-dependencies
branch
from
5fe1648 to
1835e4f
Compare
Ehesp
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.