Skip to content

fix(*): updated peer dependencies #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 19, 2025
Merged

fix(*): updated peer dependencies #1187

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a275905
fix(*): update Firebase peer dependencies to support v11 and v12
dackers86 Sep 17, 2025
a51d40c
fix(core): added translations as a core dependency
dackers86 Sep 17, 2025
e5ec6d2
fix(packages): move translations to peer dependencies in core package
dackers86 Sep 17, 2025
7e28ce2
fix(angular): remove redundant translations peer dependency
dackers86 Sep 17, 2025
406f446
chore(angular): Align angular dependencies
Ehesp Sep 17, 2025
21ec181
chore(*): merged latest
dackers86 Sep 17, 2025
d03832c
Merge branch '@invertase/v7-development' into @invertase/fix-peer-dep…
dackers86 Sep 17, 2025
7e8c704
chore(*): updated depenencies for angular and core
dackers86 Sep 17, 2025
99085ec
chore(*): merge latest
dackers86 Sep 18, 2025
36bf7d9
chore(angular): moved translations to be a main dependency
dackers86 Sep 18, 2025
1835e4f
fix(angular):removed translation dependency
dackers86 Sep 18, 2025
74c5273
chore(core): formatted dependencies in package json
dackers86 Sep 18, 2025
35c56ee
chore(angular): added licensing
dackers86 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@tanstack/angular-form": "^0.42.0",
"@types/express": "^4.17.17",
"@types/jasmine": "~5.1.0",
"@types/node": "^18.18.0",
"@types/node": "^20.19.0",
"eslint": "^9.22.0",
"eslint-config-prettier": "^9.1.0",
"firebase": "^11",
Expand Down
13 changes: 7 additions & 6 deletions packages/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@
"release": "pnpm pack --pack-destination ../../releases/"
},
"peerDependencies": {
"@angular/common": "catalog:peerDependencies",
"@angular/core": "catalog:peerDependencies",
"@firebase-ui/core": "workspace:*",
"@firebase-ui/translations": "workspace:*"
"@angular/fire": "catalog:peerDependencies"
},
"dependencies": {
"@firebase-ui/core": "workspace:*",
"@firebase-ui/translations": "workspace:*",
Copy link
Member

@Ehesp Ehesp Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed... core should pull it in

"@firebase-ui/styles": "workspace:*",
"@tanstack/angular-form": "^1.1.0",
"tslib": "^2.8.1",
"nanostores": "catalog:",
"firebase": "catalog:"
"nanostores": "catalog:"
},
"sideEffects": false,
"devDependencies": {
"@angular/core": "catalog:",
"@angular/common": "catalog:",
"@angular/forms": "catalog:",
"@angular/router": "catalog:",
"@angular/fire": "catalog:",
Expand All @@ -46,6 +46,7 @@
"@angular/compiler-cli": "catalog:",
"@angular/platform-browser": "catalog:",
"@angular/platform-browser-dynamic": "catalog:",
"firebase": "catalog:",
"karma": "^6.4.4",
"karma-chrome-launcher": "^3.2.0",
"karma-coverage": "^2.2.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
"firebase": "catalog:peerDependencies"
},
"dependencies": {
"@firebase-ui/translations": "workspace:*",
"nanostores": "catalog:",
"zod": "catalog:"
"zod": "catalog:",
"@firebase-ui/translations": "workspace:*"
Copy link
Member

@Ehesp Ehesp Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespaced imports should come at the top of the list

},
"devDependencies": {
"@types/jsdom": "catalog:",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"react-dom": "catalog:peerDependencies"
},
"dependencies": {
"@nanostores/react": "^0.8.4",
"@nanostores/react": "^1.0.0",
"@radix-ui/react-slot": "^1.2.3",
"@tanstack/react-form": "^0.41.3",
"clsx": "^2.1.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The packages also exports themes which overrides the CSS variables with preset c
```css
@import "tailwindcss";
@import "@firebase-ui/styles/tailwind";
@import "@firebase-ui/styles/themes/brualist"
@import "@firebase-ui/styles/themes/brualist";
```

## Building
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/dist.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/styles/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ describe("ButtonVariant type", () => {
it("should accept valid variant values", () => {
const primaryVariant: ButtonVariant = "primary";
const secondaryVariant: ButtonVariant = "secondary";

expect(primaryVariant).toBe("primary");
expect(secondaryVariant).toBe("secondary");
});

it("should work with buttonVariant function", () => {
const variants: ButtonVariant[] = ["primary", "secondary"];

variants.forEach((variant) => {
const result = buttonVariant({ variant });
expect(typeof result).toBe("string");
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ export const buttonVariant = cva({
},
});

export type ButtonVariant = VariantProps<typeof buttonVariant>['variant'];
export type ButtonVariant = VariantProps<typeof buttonVariant>["variant"];
Loading