-
Notifications
You must be signed in to change notification settings - Fork 544
Added section to router docs for label-based matching for Fluent Bit 4.2. Fixes #2203. #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…4.2. Fixes #2203. Signed-off-by: Eric D. Schabell <[email protected]>
WalkthroughThe router.md documentation file is updated to introduce a new "Label-based Matching" section explaining how labels and plugin names stored in chunk metadata enable stable, direct routing across configuration changes and restarts, with configuration examples and best practices. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/router.md(3 hunks)
🧰 Additional context used
🪛 GitHub Actions: Lint PRs
pipeline/router.md
[error] 770-770: FluentBit.Latin: Use 'through or by using' instead of ' via '.
🪛 GitHub Check: runner / vale
pipeline/router.md
[failure] 770-770:
[vale] reported by reviewdog 🐶
[FluentBit.Latin] Use 'through or by using' instead of ' via '.
Raw Output:
{"message": "[FluentBit.Latin] Use 'through or by using' instead of ' via '.", "location": {"path": "pipeline/router.md", "range": {"start": {"line": 770, "column": 47}}}, "severity": "ERROR"}
🔇 Additional comments (2)
pipeline/router.md (2)
7-11: Intro updates correctly establish three routing approaches.The updated introduction and bullet list clearly establish label-based matching as a distinct approach alongside tag-based and conditional routing, setting up the new documentation section logically.
757-948: New Label-based Matching section is well-structured and addresses all PR objectives.The section comprehensively covers:
- Clear explanation of how labels and plugin names enable stable routing
- Configuration examples in both YAML and classic syntax
- Benefits of the approach with concrete reasons (configuration resilience, stable restarts, type safety)
- Matching logic walkthrough (alias → generated name → ID fallback)
- Practical example demonstrating production/development routing with aliases
- Best practices subsection with actionable guidance
Documentation is thorough, examples are clear, and the integration with the updated decision table (lines 935–946) appropriately positions label-based matching alongside existing approaches.
Signed-off-by: Eric D. Schabell <[email protected]>
|
AI review passed, merging. |
Added section to router docs for label-based matching for Fluent Bit 4.2. Fixes #2203.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.