Move max_new_tokens recommendation into GenerationConfig docstring #42384
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: clarify recommended usage of max_new_tokens in generate()
This PR updates the docstring of `GenerationConfig`: - Moves the recommendation about using `max_new_tokens` over `max_length` directly into the docstring. - Clarifies that `max_length` remains for backward compatibility. - Helps users understand the recommended argument for controlling generated token length. No functionality changes are made; only documentation is updated.
Apply reviewer suggestion for clearer token explanation Co-authored-by: Steven Liu <[email protected]>
Apply reviewer suggestion for clearer token explanation Co-authored-by: Steven Liu <[email protected]>
stevhliu
approved these changes
Nov 26, 2025
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Thanks! If you can just run make fixup to fix the failing CI test, then I can merge :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves the recommendation about using
max_new_tokensovermax_lengthdirectly into the GenerationConfig docstring.It clarifies the recommended usage for users when generating sequences.
Before submitting
Who can review?
@stevhliu