-
Notifications
You must be signed in to change notification settings - Fork 31.3k
Move max_new_tokens recommendation into GenerationConfig docstring #42384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hawon223
wants to merge
11
commits into
huggingface:main
Choose a base branch
from
hawon223:fix/max_new_tokens_docstring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−3
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
39432b5
docs: clarify recommended usage of max_new_tokens in generate()
hawon223 478c3bf
Merge pull request #1 from hawon223/docs-update-generate
hawon223 8a0340e
Move max_new_tokens recommendation into GenerationConfig docstring
hawon223 ad01adc
Merge pull request #2 from hawon223/fix/max_new_tokens_docstring
hawon223 5b040b7
Remove Note about max_new_tokens and max_length
hawon223 78288a2
Update src/transformers/generation/configuration_utils.py
hawon223 b481c38
Update src/transformers/generation/configuration_utils.py
hawon223 03f72f4
Remove Note about max_new_tokens and max_length
hawon223 b774956
Docs: clean up empty line in text_generation.md
hawon223 db4013d
Docs: simplify max_length explanation in generation config
hawon223 cc35432
style: fix trailing whitespace in configuration_utils.py
hawon223 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed now